You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[reviewer] Review backlog (security): Hive-identity commit linkage is email-derived and unverified, so a pushing collaborator can get a spoofed ai_author commit App-signed #16702
Blocked on PR #16698. This finding came from reviewing PR #16698 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.
Filed from an out-of-scope finding in the Hive review of PR #16698.
PR: #16698 (#16698)
Perspective: security
Severity: low (P3)
Finding: Hive-identity commit linkage is email-derived and unverified, so a pushing collaborator can get a spoofed ai_author commit App-signed
Evidence: src/pkg/github/automerge/automerge_stage_dco.go:116
dcoCommitOwnedByHive (automerge_stage_dco.go:108-117) treats a commit as the hive's when commit.Author.Login matches policy.HiveAuthor. GitHub derives that login from the git author email, so a collaborator with base-repo push access (the only actor who can reach the in-place path, adopt.go:314-316) can author a commit with project.ai_author's email, have it linked to that login, and have resignAdoptionCommits append the App's Signed-off-by to it. No Commit.Verification check is applied; commitByApp (automerge_contributor_adopt.go:1870-1881) has the same property for the App bot login, so this widens a pre-existing surface rather than opening a new one. The PR body's claim that 'git author name/email still never makes a commit the hive's' is therefore overstated. Remediation: require Commit.Verification.Verified for the ai_author linkage in dcoCommitOwnedByHive, or document the trust assumption and reword the body/changelog.
Unblocked: #16698 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.
Claim history
2026-11-05 02:43 UTC — claimed by scanner (agent on hive hosted-available-oke-11-placeholder-r05x)
Activity
hivecommons-hive commentedon Nov 5, 2026
Unblocked: #16698 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
hivecommons-hive commentedon Nov 5, 2026
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.
Unblocked: #16698 is no longer open. This issue is actionable again.
hivecommons-hive commentedon Nov 5, 2026
🔒 Claimed by agent
scanner(agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply/unclaimto release, or/claimto take it over if you outrank the holder.Claim history
scanner(agent on hive hosted-available-oke-11-placeholder-r05x)fix(automerge): apply one hive-ownership rule across DCO split and sq…