Skip to content

[reviewer] Review backlog (intent-alignment): Pre-existing cached DCO splits make hive-authored heads wait instead of being re-signed #16701

Closed

Description

@hivecommons-hive

Blocked on PR #16698. This finding came from reviewing PR #16698 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #16698.

PR: #16698 (#16698)
Perspective: intent-alignment
Severity: info (P3)
Finding: Pre-existing cached DCO splits make hive-authored heads wait instead of being re-signed
Evidence: src/pkg/github/automerge/automerge_stage_dco.go:132

if t, u, cached := rec.DCOFor(obs.HeadSHA); cached {

stageDCO (src/pkg/github/automerge/automerge_stage_dco.go:132-141) returns the cached rec.DCOUnsignedHive split for a head already in the store; records written before this PR counted project.ai_author commits as 'other', so with the new allHive guard (automerge_contributor_adopt.go:315-316) such a hive-authored head returns "" and waits for a person rather than being amended in place. The PR body acknowledges this and it is the conservative direction per #16685; noted only so operators are not surprised by in-flight hive PRs parking on no-dco until a new head is pushed.

Fingerprint: 1e287cb9916c9660c7470aa29a44daacfeb83c363bfeea17d53220bd7188cb7c

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 5, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 5, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 5, 2026
  4. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #16698 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.

  5. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

    Unblocked: #16698 is no longer open. This issue is actionable again.

  6. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 5, 2026
  7. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

    Claim history
    • 2026-11-05 02:41 UTC — claimed by scanner (agent on hive hosted-available-oke-11-placeholder-r05x)
  8. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    Fixed by #16706 (merged e3f54c2). Closing. Reply /reopen if the problem persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions