Skip to content

[reviewer] Review backlog (correctness): Docs say sweep runs after every CI enrichment pass; it is skipped in API-budget conserve mode #16695

Closed

Description

@hivecommons-hive

Blocked on PR #16681. This finding came from reviewing PR #16681 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #16681.

PR: #16681 (#16681)
Perspective: correctness
Severity: info (P3)
Finding: Docs say sweep runs after every CI enrichment pass; it is skipped in API-budget conserve mode
Evidence: src/docs/operator-reference/runtime-and-quota.md:265

- **Gated workflow runs are approved for trusted heads.** After each CI

src/docs/operator-reference/runtime-and-quota.md:265 and src/docs/webhooks.md:118 state the approval sweep runs after each CI enrichment pass, but src/cmd/hive/main_eval_cycle.go:584-586 only calls SweepWorkflowApprovals when !budgetDecision.SkipOptional. Under budget conserve mode gated heads wait until the next non-skipped cycle. Advisory wording precision only; no behavioural defect.

Fingerprint: e829f27f65e1e694ff8046932696af87b639584eb082c293476facce1eda8113

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 5, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 5, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 5, 2026
  4. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

    Unblocked: #16681 is no longer open. This issue is actionable again.

  5. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 5, 2026
  6. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: source PR #16681 closed unmerged — re-triage against current base. A superseding PR often lands the same lines, so the finding may still apply; close this item only if it no longer does.

  7. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

    Claim history
    • 2026-11-05 08:39 UTC — claimed by scanner (agent on hive hosted-available-oke-11-placeholder-r05x)
  8. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    Fixed by #16736 (merged 6ed3e5e). Closing. Reply /reopen if the problem persists.

  9. github-actions commented on Nov 5, 2026

    @github-actions
    Contributor

    @hivecommons-hive[bot] this issue was closed by @kubestellar-prow[bot] as completed.

    If this was closed by a merged PR, the fix only takes effect once it ships in a tagged release and your deployment updates to it — check your running version against the fix before concluding the fix failed.

    If you are still seeing the problem, comment /reopen and it will be reopened for you — you do not need write access. Please add what you are still observing (running version, logs, steps) so it is not closed the same way again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions