Skip to content

[reviewer] Review backlog (correctness): Visible 'Navigation' label is hidden at phone widths (<=600px) #16690

Closed

Description

@hivecommons-hive

Filed from an out-of-scope finding in the Hive review of PR #16688.

PR: #16688 (#16688)
Perspective: correctness
Severity: info (P3)
Finding: Visible 'Navigation' label is hidden at phone widths (<=600px)
Evidence: src/pkg/dashboard/static-src/css/agent-detail.css:333

.oc-topbar .nav-chip--action .nav-chip__label,

Carried from v5 #16678, not introduced by the merge. The drawer toggle now carries class nav-chip--action (topbar.html:4), and agent-detail.css:333 inside @media (max-width: 600px) hides .oc-topbar .nav-chip--action .nav-chip__label, so at <=600px the button is icon-only again (only title/aria-label 'Open navigation' remain). The reporter's ~838px window (#16654) does get the visible label (toggle shown <=1024px per agent-detail.css:279/306), so the fix addresses the filed case; phones keep the bare glyph. Consider exempting #oc-drawer-toggle from that rule if a visible label is wanted there.

Fingerprint: 3e8850f4cecf20cfa04e5a6ac047fcc7ff55837be6f5e81d5670f85bf9fdd085

filed by Hive review backlog

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 5, 2026
  2. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by @Karibhou released (lease revoked).

    Claim history
    • 2026-11-05 01:46 UTC — claimed by scanner (agent on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-05 14:48 UTC — claimed by Karibhou (contributor on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-05 14:52 UTC — released by Karibhou (contributor; lease revoked)
  3. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    @Karibhou you now hold this issue (contributor on hive hosted-available-oke-11-placeholder-r05x); the claim ledger comment above tracks it. Reply /unclaim to release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.hive/re-authored

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions