You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[reviewer] Review backlog (security): In-place DCO repair now appends the App's Signed-off-by to non-hive commits on hive-authored PRs #16685
Blocked on PR #16683. This finding came from reviewing PR #16683 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.
Filed from an out-of-scope finding in the Hive review of PR #16683.
PR: #16683 (#16683)
Perspective: security
Severity: low (P3)
Finding: In-place DCO repair now appends the App's Signed-off-by to non-hive commits on hive-authored PRs
Evidence: src/pkg/github/automerge/automerge_contributor_adopt.go:338
v5 #16648 (carried verbatim by this merge) relaxes adoptionDCORepairMode: for a hiveAuthoredPR on a pushable base-repo head, AdoptModeInPlace is chosen even when obs.Detail.DCOUnsignedOther > 0 (src/pkg/github/automerge/automerge_contributor_adopt.go:338), where previously it required DCOUnsignedHive == DCOUnsigned && DCOUnsignedOther == 0. repairAdoptedDCOInPlace -> resignAdoptionCommits then appends hgithub.BotSignedOffByTrailer(AppBotLogin) to every unsigned single-parent commit regardless of author (automerge_contributor_adopt.go:1414, :1434). Consequence: a collaborator's unsigned commit pushed onto a hive-authored branch gets a DCO trailer asserted by the App bot rather than by that commit's author. Exposure is limited to users with push access to the base repo, and the policy was reviewed on v5, so this is pre-existing relative to the forward-merge contract; flagging for a follow-up decision on whether in-place repair should skip or refuse non-hive-authored unsigned commits (e.g. keep the DCOUnsignedOther == 0 condition even when hiveAuthored, falling back to "" / wait-for-human).
Unblocked: #16683 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.
Claim history
2026-11-05 01:25 UTC — claimed by Karibhou (contributor on hive hosted-available-oke-11-placeholder-r05x)
2026-11-05 01:51 UTC — released by Karibhou (contributor; lease revoked)
2026-11-05 02:02 UTC — claimed by scanner (agent on hive hosted-available-oke-11-placeholder-r05x)
Activity
hivecommons-hive commentedon Nov 5, 2026
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.
Unblocked: #16683 is no longer open. This issue is actionable again.
hivecommons-hive commentedon Nov 5, 2026
Unblocked: #16683 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
hivecommons-hive commentedon Nov 5, 2026
🔒 Claimed by agent
scanner(agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply/unclaimto release, or/claimto take it over if you outrank the holder.Claim history
Karibhou(contributor on hive hosted-available-oke-11-placeholder-r05x)Karibhou(contributor; lease revoked)scanner(agent on hive hosted-available-oke-11-placeholder-r05x)