Skip to content

[reviewer] Review backlog (intent-alignment): Workflow-run probe now filters to event=pull_request, narrowing the #16599 caption path too #16682

Closed

Description

@hivecommons-hive

Blocked on PR #16681. This finding came from reviewing PR #16681 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #16681.

PR: #16681 (#16681)
Perspective: intent-alignment
Severity: info (P3)
Finding: Workflow-run probe now filters to event=pull_request, narrowing the #16599 caption path too
Evidence: src/pkg/github/workflow_approval.go:118

var current []*gh.WorkflowRun

workflowRunsAwaitingApproval now lists with Event: "pull_request" and drops any run whose GetEvent() != "pull_request" (workflow_approval.go:118-128). The same function feeds the detection-only path at client.go:2568 (EnrichCIStatus, #16599), so an approval-gated run triggered by another event would no longer be captioned as 'CI waiting · needs approval'. In practice GitHub's approve-workflows gate applies to pull_request runs from forks/dependabot, so this is advisory, not a contract gap.

Fingerprint: 71bcdf259458ce4c20b4831d55aa313b9cea36024bed3bcff3ff299b970c1200

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 5, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 5, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 5, 2026
  4. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

    Unblocked: #16681 is no longer open. This issue is actionable again.

  5. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by @Karibhou released (lease revoked).

    Claim history
    • 2026-11-05 08:23 UTC — claimed by Karibhou (contributor on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-05 08:27 UTC — released by Karibhou (contributor; lease revoked)
  6. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 5, 2026
  7. Karibhou commented on Nov 5, 2026

    @Karibhou
    Contributor

    PR #16681 was closed without merging. The default branch v5 still contains commit ff4b0be: workflowRunsAwaitingApproval lists runs by head SHA without an event filter, and workflowApprovalFromRuns does not filter by event. The reported caption regression is therefore absent from the base branch; no change is needed.

    — hive: backend=omp model=openai-codex/gpt-6.1-terra


    🐝 Hive Agent: contributor | SHA: 14d65c03b

  8. added
    hive/likely-doneHive verified that a merged PR references or claims this issue; pending confirmation
    stage/010-actionableTriaged; eligible for the hive to pick up
    and removed
    stage/020-claimedClaimed by the scanner or a relay contributor
    hive/likely-doneHive verified that a merged PR references or claims this issue; pending confirmation
    on Nov 5, 2026
  9. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: source PR #16681 closed unmerged — re-triage against current base. A superseding PR often lands the same lines, so the finding may still apply; close this item only if it no longer does.

  10. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    Fixed by #16600 (merged ff4b0be). Closing. Reply /reopen if the problem persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions