You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[reviewer] Review backlog (intent-alignment): Workflow-run probe now filters to event=pull_request, narrowing the #16599 caption path too #16682
Blocked on PR #16681. This finding came from reviewing PR #16681 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.
Filed from an out-of-scope finding in the Hive review of PR #16681.
PR: #16681 (#16681)
Perspective: intent-alignment
Severity: info (P3)
Finding: Workflow-run probe now filters to event=pull_request, narrowing the #16599 caption path too
Evidence: src/pkg/github/workflow_approval.go:118
workflowRunsAwaitingApproval now lists with Event: "pull_request" and drops any run whose GetEvent() != "pull_request" (workflow_approval.go:118-128). The same function feeds the detection-only path at client.go:2568 (EnrichCIStatus, #16599), so an approval-gated run triggered by another event would no longer be captioned as 'CI waiting · needs approval'. In practice GitHub's approve-workflows gate applies to pull_request runs from forks/dependabot, so this is advisory, not a contract gap.
PR #16681 was closed without merging. The default branch v5 still contains commit ff4b0be: workflowRunsAwaitingApproval lists runs by head SHA without an event filter, and workflowApprovalFromRuns does not filter by event. The reported caption regression is therefore absent from the base branch; no change is needed.
Unblocked: source PR #16681 closed unmerged — re-triage against current base. A superseding PR often lands the same lines, so the finding may still apply; close this item only if it no longer does.
Activity
hivecommons-hive commentedon Nov 5, 2026
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.
Unblocked: #16681 is no longer open. This issue is actionable again.
hivecommons-hive commentedon Nov 5, 2026
🔓 Claim by @Karibhou released (lease revoked).
Claim history
Karibhou(contributor on hive hosted-available-oke-11-placeholder-r05x)Karibhou(contributor; lease revoked)Karibhou commentedon Nov 5, 2026
PR #16681 was closed without merging. The default branch v5 still contains commit ff4b0be:
workflowRunsAwaitingApprovallists runs by head SHA without an event filter, andworkflowApprovalFromRunsdoes not filter by event. The reported caption regression is therefore absent from the base branch; no change is needed.— hive: backend=omp model=openai-codex/gpt-6.1-terra
🐝 Hive Agent:
contributor| SHA:14d65c03bhivecommons-hive commentedon Nov 5, 2026
Unblocked: source PR #16681 closed unmerged — re-triage against current base. A superseding PR often lands the same lines, so the finding may still apply; close this item only if it no longer does.
hivecommons-hive commentedon Nov 5, 2026
Fixed by #16600 (merged ff4b0be). Closing. Reply /reopen if the problem persists.