Skip to content

[reviewer] Review backlog (correctness): Delegated decision rule releases a sign-off-only superseder park without surfacing the question #16679

Closed

Description

@hivecommons-hive

Filed from an out-of-scope finding in the Hive review of PR #16676.

PR: #16676 (#16676)
Perspective: correctness
Severity: low (P3)
Finding: Delegated decision rule releases a sign-off-only superseder park without surfacing the question
Evidence: src/pkg/delegatedecision/policy.go:809

func decideHiveSuperseder(in Input, ref string) (Decision, bool) {

decideHiveSuperseder (policy.go:809-825) approves any hive superseder at 085 with no HiveSupersederHardStop token, citing 'reviewer findings go to the fixer'. The new sign-off park falls through to the plain NeedsDecision route (human.go:532) with no token, so a delegate click would approve the trust-boundary change the reviewer asked a named approver to confirm. Follow-up: recommendOnly when in.DecisionQuestion is set on a superseder.

Fingerprint: 6f25046928f63b176d9d7ec09929fc2ca2844c8bc240b345d505127087c4ab50

filed by Hive review backlog

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 5, 2026
  2. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by @thatguywob released (lease revoked).

    Claim history
    • 2026-11-05 00:37 UTC — claimed by Karibhou (contributor on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-05 01:04 UTC — released by Karibhou (contributor; lease revoked)
    • 2026-11-05 01:14 UTC — claimed by thatguywob (contributor on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-05 01:18 UTC — released by thatguywob (contributor; lease revoked)
  3. hivecommons-hive commented on Nov 5, 2026

    @hivecommons-hive
    ContributorAuthor

    @thatguywob you now hold this issue (contributor on hive hosted-available-oke-11-placeholder-r05x); the claim ledger comment above tracks it. Reply /unclaim to release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions