Skip to content

Hive-superseding PR with unanimous requires_human sign-off loops fixer → exhausted → re-author (#16398→#16456→#16607) #16675

Closed

Description

@clubanderson

Symptom

#16265 shows child PR #16607 on "PR in progress" for 9h with stage/070-fixing, CI green (11/11 required), and no decision pill. It is the third re-authoring of the same change: #16398 (closed Nov 3, superseded by #16456), #16456 (closed Nov 4 14:22, "the hive's fixer gave up on this PR after 6 attempts"), #16607 (opened 14:45, already at 5 fix attempts by 19:09 ET).

Evidence (spoke hive-oke, pod hive-6cfc6c576b-vl7r9)

Review bundle for b5c1f96c: all 5 perspectives returned requires_human, each with decision_requested: true, decision_risk_high: true, question "@hanthor should confirm that the hive-merge relay may now App-merge trusted-author pin-only PRs touching auto_merge.human_merge_paths". Security's only finding is severity info: "Needs approver sign-off, not a code fix."

review-verdicts.json aggregate for the same head:

verdict: changes_requested   fix_cycle: true   requires_human: false   decision_requested: (dropped)
reasons: "hive-authored superseding PR: reviewer requires_human routed to the fixer; auto-merges once CI and review are clean"
perspectives: {correctness, docs-currency, intent-alignment, security, style}: changes_requested

Logs:

stage labels: reviewer verdict route ... raw_verdict=changes_requested decision_requested=false stage=070-fixing reason=reviewer-verdict:changes_requested
review fix dispatch excluded ... reason=pending-fix-already-dispatched attempts=5
automerge sweep review gate holding merge ... outcome=changes-requested:correctness,docs-currency,intent-alignment,security,style

Stage tracker item: review_activity.state=changes_requested, caption "Review findings · awaiting author", code_activity "Remediating · scanner", human_attention unset — the operator was never shown a decision.

Root cause

review.hiveSupersedingFixRoute (owner rule: a hive superseding PR auto-merges, requires_human goes to the fixer) applies even when no perspective found anything to fix. The fixer gets kicked with a sign-off question, pushes nothing, the cycle hits the cap, fixer-exhausted re-authors the PR, and the fresh PR gets the same review and the same route. stagelabels.RouteHuman likewise captions a superseder's requires_human as "goes to the fixer" (070) regardless of whether a fixer will be dispatched.

Fix

  • Aggregation: when every requires_human report explicitly requests a decision and carries no in-scope finding above info, and no perspective is changes_requested/reject, the superseder fix route does not apply; the aggregate stays requires_human with its decision question, so no fixer is dispatched and no re-author follows.
  • RouteHuman: a superseder requires_human that still carries its decision question parks at 085 needs-decision (approve / request-changes actions), not 070.
  • Tracker: review chevron caption "Waiting on a human approver · reviewer verified, needs sign-off" for that aggregate shape.

Manual unstick for #16607: stage/070-fixing → stage/085-needs-decision; approval left to the owner.

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 5, 2026
  2. github-actions commented on Nov 5, 2026

    @github-actions
    Contributor

    @clubanderson this issue was closed by @hivecommons-hive[bot] as completed.

    If this was closed by a merged PR, the fix only takes effect once it ships in a tagged release and your deployment updates to it — check your running version against the fix before concluding the fix failed.

    If you are still seeing the problem, comment /reopen and it will be reopened for you — you do not need write access. Please add what you are still observing (running version, logs, steps) so it is not closed the same way again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions