You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[reviewer] Review backlog (security): Auto-decide only treats workflow-path edits as policy sign-off when the PR is from a fork #16638
Blocked on PR #16524.src/pkg/review/decision_question_class.go does not exist on v6; this finding tracks code the PR introduces, so there is nothing to ship until it lands. The hive lifts the blocked label when the PR merges or closes.
Filed from an out-of-scope finding in the Hive review of PR #16524.
PR: #16524 (#16524)
Perspective: security
Severity: low (P3)
Finding: Auto-decide only treats workflow-path edits as policy sign-off when the PR is from a fork
Evidence: src/pkg/review/decision_question_class.go:118
ClassifyDecisionQuestion returns DecisionQuestionPolicySignOff for .github/workflows/** only when in.FromFork is true (decision_question_class.go:118-119); decisionPolicyPaths (lines 68-76) does not include workflow paths, and the owner-only regexes (lines 88-101) match 'github permissions'/'app permissions' but not a bare 'permissions:' scope question. A hive-authored same-repo PR that widens a workflow permission scope and draws a bare reviewer question (no in-scope finding, no DecisionFinding, no changes_requested — reviewQuestionUnresolvedFindings, review_question_autodecide.go:254-271) is therefore classified Scope and routed through runDelegatedDecision to approve. Pre-existing v5 design (#16598), forwarded unchanged by this top-up; hardening suggestion: apply decisionWorkflowPaths regardless of FromFork, or add \bpermissions?\b / \bscopes?\b to decisionOwnerOnlyGuards.
Unblocked: #16524 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
Activity
hivecommons-hive commentedon Nov 4, 2026
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.
Unblocked: #16524 is no longer open. This issue is actionable again.
hivecommons-hive commentedon Nov 4, 2026
Unblocked: #16524 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
hivecommons-hive commentedon Nov 4, 2026
🔓 Claim by @Karibhou released (lease revoked).
Claim history
Karibhou(contributor on hive hosted-available-oke-11-placeholder-r05x)Karibhou(contributor; lease revoked)🐛 fix: require sign-off for workflow review questions (#16646)