Skip to content

[reviewer] Review backlog (security): Auto-decide only treats workflow-path edits as policy sign-off when the PR is from a fork #16638

Closed

Description

@hivecommons-hive

Blocked on PR #16524. src/pkg/review/decision_question_class.go does not exist on v6; this finding tracks code the PR introduces, so there is nothing to ship until it lands. The hive lifts the blocked label when the PR merges or closes.

Filed from an out-of-scope finding in the Hive review of PR #16524.

PR: #16524 (#16524)
Perspective: security
Severity: low (P3)
Finding: Auto-decide only treats workflow-path edits as policy sign-off when the PR is from a fork
Evidence: src/pkg/review/decision_question_class.go:118

if in.FromFork && intent.PathMatchesAny(p, decisionWorkflowPaths) {

ClassifyDecisionQuestion returns DecisionQuestionPolicySignOff for .github/workflows/** only when in.FromFork is true (decision_question_class.go:118-119); decisionPolicyPaths (lines 68-76) does not include workflow paths, and the owner-only regexes (lines 88-101) match 'github permissions'/'app permissions' but not a bare 'permissions:' scope question. A hive-authored same-repo PR that widens a workflow permission scope and draws a bare reviewer question (no in-scope finding, no DecisionFinding, no changes_requested — reviewQuestionUnresolvedFindings, review_question_autodecide.go:254-271) is therefore classified Scope and routed through runDelegatedDecision to approve. Pre-existing v5 design (#16598), forwarded unchanged by this top-up; hardening suggestion: apply decisionWorkflowPaths regardless of FromFork, or add \bpermissions?\b / \bscopes?\b to decisionOwnerOnlyGuards.

Fingerprint: 0e17dd75c7872a3ddfcb86f4779194a1756a6b5e14a1b0ec67cd1ab2966db3df

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 4, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 4, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 4, 2026
  4. hivecommons-hive commented on Nov 4, 2026

    @hivecommons-hive
    ContributorAuthor

    Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

    Unblocked: #16524 is no longer open. This issue is actionable again.

  5. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 4, 2026
  6. hivecommons-hive commented on Nov 4, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #16524 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.

  7. hivecommons-hive commented on Nov 4, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by @Karibhou released (lease revoked).

    Claim history
    • 2026-11-04 18:57 UTC — claimed by Karibhou (contributor on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-04 19:00 UTC — released by Karibhou (contributor; lease revoked)
  8. added
    hive/likely-doneHive verified that a merged PR references or claims this issue; pending confirmation
    and removed on Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.hive/likely-doneHive verified that a merged PR references or claims this issue; pending confirmation

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions