Skip to content

🐛 Activity Monitor: re-review pending is attributed to the PR author; CI caption stale on heads with >50 check contexts #16635

Closed

Description

@clubanderson

Observed on #16615 (author @thatguywob, a clanker). The row read:

  • pill: waiting on 🤖 @thatguywob · re-review pending
  • CI chevron ACTIVE: CI 7/11 · test not reported
  • Review chevron: icon only

Ground truth at the time: head d88928e, every required check green on it (only prow tide pending), hive's reviewer had last reviewed the previous head 6384f9b, operator re-approved at d88928e. So the true state was "CI complete and green; hive's reviewer owes a re-review of d88928e" — nothing was waiting on the author. Operator question: "are we waiting on the clanker or are we in CI? is the pill accurate?"

Three defects:

  1. Attribution. rework.state == pushed appends re-review pending to the waiting on @<author> pill. A re-review is the hive reviewer's debt, not the author's. The pill should read waiting on 🐝 hive reviewer · re-review of d88928e, and only name the author when the pushed head asks them for something (red CI on it, changes requested on it, a conflict nobody in the hive rebases).

  2. Stale CI caption (root cause). The GraphQL PR batch asks statusCheckRollup { contexts(first: 50) } with no totalCount, and graphQLCheckRuns returns ok=true on a truncated page. d88928e had 71 check runs + 2 statuses (the test matrix alone is ~30 jobs); the required aggregates test, golangci-lint, gosec, govulncheck fell past the page, so enrichPRCI trusted the cache instead of the paginated REST listing and the dashboard reported required check "test" hasn't reported on an all-green head.

  3. Consistency. With CI complete and green and a re-review owed, the Review chevron must be the active one (Review 0/5 · re-review of d88928e) and CI the icon-only green ring.

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 4, 2026
  2. added a commit that references this issue on Nov 4, 2026
    73ccd4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions