Skip to content

🐛 CI chevron stays icon-only with a partly filled ring while checks are still running #16631

Closed

Description

@clubanderson

Post-roll of #16600 (352163f), row for PR #16628: the CI chevron rendered INACTIVE as a green ring only partly filled (13 of 19 segments) with no text, while the Review chevron was active "Review 0/5 · in progress".

A CI ring that is not full means checks are still running on this head, so per the canonical chevron spec the CI chevron must be ACTIVE (amber, "CI 13/19 · running") simultaneously with Review. Icon-only green CI is permitted only when the ring is complete (passed == total, nothing pending).

Causes:

  • stageTrackerCIActivity (required-check path) ranks missing/unknown/failing above running, so a not-yet-reported or red neighbour hid a check in motion → state ≠ running → JS stageTrackerTrackRunning false → todo glyph with a partial ring.
  • The no-required-set path never looked at check-run motion at all.
  • Active was only set while the observation was fresh.

Fix: state = running whenever any check on the head is in_progress (queued when only waiting for a runner), with the red count carried in the caption (CI running · 2/3 checks done · 1 failing); passing only when every required check passed; JS treats a partial ring (passed+failed < total) with no settled word as running. Fixtures: CI 13/19 + review in progress ⇒ both active; CI 19/19 + review in progress ⇒ CI green icon-only, Review active.

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 4, 2026
  2. added a commit that references this issue on Nov 4, 2026
    8b0db18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions