Skip to content

Activity Monitor: red Review chevron says "Review activity unknown · last observed changes_requested" #16617

Closed

Description

@clubanderson

On the Activity Monitor row for #16607 (head b5c1f96…) the Review chevron is red, yet its tooltip reads:

Review: Review 5/5 · changes requested · Review activity unknown · last observed changes_requested · Review findings · awaiting author · correctness requires human: … · head b5c1f96… · verified-review-bundle · stale · 2026-11-04T16:00:26Z · since 2026-11-04T14:54:01Z

User: "how is review activity unknown? it's a red icon. it must be known which perspective failed and why."

Root cause

The spoke's /api/stage-tracker payload is correct and unambiguous — review_activity for the head is state: changes_requested, source: verified-review-bundle, perspectives_done/total: 5/5, with a blocker naming the finding. The contradiction is produced by the tooltip builder in static-src/js/tracker-row-strip.js (stageTrackerActivityTrackHtml): it treats every observation older than the 2-minute freshness window as "not known" and prefixes the caption with <Track> activity unknown · last observed <state>, while the chevron colour is still derived from state. A settled verdict (approved / changes_requested / human_decision, passing / failing) from a verified bundle on the current head does not go stale — only motion (reviewing / running) does. The 2-minute gate was meant for the pulse, not for the verdict.

Secondly, the backend never exposes the per-perspective verdicts the bundle already holds, so even a correct tooltip cannot say which perspective failed and why.

Fix

  1. Frontend: a settled verdict on the current head keeps its caption; staleness becomes a suffix (observed 15m ago) and activity unknown · last observed … is reserved for states that imply motion.
  2. Backend: review_activity.perspectives[] {name, verdict, summary} from the latest bundle verdicts on the current head; the caption names the first failing perspective (correctness ✗: <summary>).
  3. The tooltip is composed from one state: caption, one line per perspective, then head / source / observed / since — never both unknown and a verdict.

Activity

  1. hivecommons-hive commented on Nov 4, 2026

    @hivecommons-hive
    Contributor

    🔓 Claim by @thatguywob released (lease revoked).

    Claim history
    • 2026-11-04 16:19 UTC — claimed by thatguywob (contributor on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-04 16:26 UTC — released by thatguywob (contributor; lease revoked)
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 4, 2026
  3. github-actions commented on Nov 4, 2026

    @github-actions
    Contributor

    @clubanderson this issue was closed by @hivecommons-hive[bot] as completed.

    If this was closed by a merged PR, the fix only takes effect once it ships in a tagged release and your deployment updates to it — check your running version against the fix before concluding the fix failed.

    If you are still seeing the problem, comment /reopen and it will be reopened for you — you do not need write access. Please add what you are still observing (running version, logs, steps) so it is not closed the same way again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions