Skip to content

[reviewer] Review backlog (correctness): Redundant Issues.Get each retry pass before the store override #16586

Closed

Description

@hivecommons-hive

Blocked on PR #16583. This finding came from reviewing PR #16583 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #16583.

PR: #16583 (#16583)
Perspective: correctness
Severity: info (P3)
Finding: Redundant Issues.Get each retry pass before the store override
Evidence: src/pkg/github/automerge/automerge_stage_labels.go:1140

if prev, ok := store.Get(key); ok && prev.Reauthored() {

autoReauthorTarget performs an Issues.Get (automerge_hive_reauthor.go:80) on every pass for an exhausted hive PR, and only afterwards does the caller override the target from prev.Reauthored() (automerge_stage_labels.go:1140-1142); checking the store record first would avoid one API call per retry pass while the close is pending. Cosmetic.

Fingerprint: 3c298b713b7f5e740d347fc5eb0ec1ba88aea93ab403755938d3084e8b92c951

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 4, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 4, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 4, 2026
  4. hivecommons-hive commented on Nov 4, 2026

    @hivecommons-hive
    ContributorAuthor

    Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

    Unblocked: #16583 is no longer open. This issue is actionable again.

  5. hivecommons-hive commented on Nov 4, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by agent scanner released (holding agent relaunched).

    Claim history
    • 2026-11-04 13:10 UTC — claimed by thatguywob (contributor on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-04 13:16 UTC — released by thatguywob (contributor; lease revoked)
    • 2026-11-04 13:41 UTC — claimed by scanner (agent on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-04 14:18 UTC — released by scanner (agent; holding agent relaunched)
  6. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 4, 2026
  7. hivecommons-hive commented on Nov 4, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #16583 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions