You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[reviewer] Review backlog (style): Org-qualification of bare repo names duplicated instead of reusing one helper #16559
Blocked on PR #16553.src/cmd/hive/fixer_queue.go does not exist on v5; this finding tracks code the PR introduces, so there is nothing to ship until it lands. The hive lifts the blocked label when the PR merges or closes.
Filed from an out-of-scope finding in the Hive review of PR #16553.
PR: #16553 (#16553)
Perspective: style
Severity: low (P3)
Finding: Org-qualification of bare repo names duplicated instead of reusing one helper
Evidence: src/cmd/hive/fixer_queue.go:50
The org + "/" + repo qualification now appears in fixerQueueKey (src/cmd/hive/fixer_queue.go:50-52) and reconcileDeferredFixQueue (src/cmd/hive/fixer_queue.go:68-71), and the same rule already exists unexported as reviewQueueFullRepo in src/pkg/github/review_queue.go:327-334. The fixerQueueKey comment itself states every writer/reader must agree on the qualified form; exporting reviewQueueFullRepo (or routing reconcileDeferredFixQueue through fixerQueueKey) would make that agreement structural rather than by convention. Behaviour is correct today; this is a maintainability follow-up only.
Unblocked: #16553 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
Activity
hivecommons-hive commentedon Nov 4, 2026
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.
Unblocked: #16553 is no longer open. This issue is actionable again.
hivecommons-hive commentedon Nov 4, 2026
Unblocked: #16553 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
hivecommons-hive commentedon Nov 4, 2026
🔓 Claim by @thatguywob released (lease revoked).
Claim history
thatguywob(contributor on hive hosted-available-oke-11-placeholder-r05x)thatguywob(contributor; lease revoked)🌱 refactor: share review queue repository qualification (#16571)