Skip to content

[reviewer] Review backlog (style): Org-qualification of bare repo names duplicated instead of reusing one helper #16559

Closed

Description

@hivecommons-hive

Blocked on PR #16553. src/cmd/hive/fixer_queue.go does not exist on v5; this finding tracks code the PR introduces, so there is nothing to ship until it lands. The hive lifts the blocked label when the PR merges or closes.

Filed from an out-of-scope finding in the Hive review of PR #16553.

PR: #16553 (#16553)
Perspective: style
Severity: low (P3)
Finding: Org-qualification of bare repo names duplicated instead of reusing one helper
Evidence: src/cmd/hive/fixer_queue.go:50

The org + "/" + repo qualification now appears in fixerQueueKey (src/cmd/hive/fixer_queue.go:50-52) and reconcileDeferredFixQueue (src/cmd/hive/fixer_queue.go:68-71), and the same rule already exists unexported as reviewQueueFullRepo in src/pkg/github/review_queue.go:327-334. The fixerQueueKey comment itself states every writer/reader must agree on the qualified form; exporting reviewQueueFullRepo (or routing reconcileDeferredFixQueue through fixerQueueKey) would make that agreement structural rather than by convention. Behaviour is correct today; this is a maintainability follow-up only.

Fingerprint: f2af38f65096cbac2d03cb033a1d74ea29af0c78b01f04b00bcaec8e8599f33f

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 4, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 4, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 4, 2026
  4. hivecommons-hive commented on Nov 4, 2026

    @hivecommons-hive
    ContributorAuthor

    Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

    Unblocked: #16553 is no longer open. This issue is actionable again.

  5. hivecommons-hive commented on Nov 4, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #16553 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.

  6. hivecommons-hive commented on Nov 4, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by @thatguywob released (lease revoked).

    Claim history
    • 2026-11-04 08:05 UTC — claimed by thatguywob (contributor on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-04 08:08 UTC — released by thatguywob (contributor; lease revoked)
  7. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions