Skip to content

[reviewer] Review backlog (correctness): Fallback config fields use undefined .mt-3 utility class #16557

Closed

Description

@hivecommons-hive

Blocked on PR #16541. This finding came from reviewing PR #16541 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #16541.

PR: #16541 (#16541)
Perspective: correctness
Severity: low (P3)
Finding: Fallback config fields use undefined .mt-3 utility class
Evidence: src/pkg/dashboard/static-src/js/config-features.js:538

<div class="config-field mt-3">

Commit daf4be2 replaced style="margin-top:10px" on the two new fallback config-field divs with class="config-field mt-3" (config-features.js:538 and :542). No stylesheet under src/pkg/dashboard/static-src/css/ defines .mt-3 (nor any .mt-N utility), so the class is a no-op and the two fields render with no top margin, unlike the neighbouring fields that keep inline margin-top:10px. Same pre-existing pattern exists in ~10 other fragments, so this is cosmetic and adjacent, not a blocker. Fix: define the utility once, e.g. in an existing CSS fragment: .mt-3 { margin-top: var(--sp-3); } (or 10px to match neighbours).

Fingerprint: 624701d5f92c1ca3ac8a55bdcbf220780ecbc4f767802e2e7170f43ae010b56a

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 4, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 4, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 4, 2026
  4. hivecommons-hive commented on Nov 4, 2026

    @hivecommons-hive
    ContributorAuthor

    Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

    Unblocked: #16541 is no longer open. This issue is actionable again.

  5. hivecommons-hive commented on Nov 4, 2026

    @hivecommons-hive
    ContributorAuthor

    🌱 Good first issue — bring your own coding agent

    Hi! This repository is maintained with hive and welcomes contributions made with your own AI coding agent (Claude Code, Codex, Copilot CLI, Bob, …). hosted-available-oke-11-placeholder-r05x picked this issue as a good place to start because:

    • scoped to two packages (hivecommons/hive, pkg/dashboard)
    • short, focused description

    How to land it (no waiting on a human):

    1. Claim it through the relay: open https://hosted-kubestellar-hive-ojv6.hive.hivecommons.dev/contribute?issue=hivecommons%2Fhive%2316557 and sign in with GitHub. Claiming stamps the issue so hive leaves it to you.
    2. Fork or branch, make the change with your agent, and sign each commit with DCO (git commit -s).
    3. Open a PR whose description says Fixes #16557 — that closing keyword is how hive's contributor lane links the PR to your claim.
    4. Hive runs CI and merges green PRs from claimed contributors automatically.
    Paste this to your agent
    Fix #16557 in github.com/hivecommons/hive (https://github.com/hivecommons/hive/issues/16557). First open https://hosted-kubestellar-hive-ojv6.hive.hivecommons.dev/contribute?issue=hivecommons%2Fhive%2316557 and claim the issue through the hive relay (sign in with GitHub). Work on a fork/branch; keep the change scoped to the issue; sign every commit with DCO (git commit -s); open a PR whose description contains the line 'Fixes #16557' so the hive's contributor lane can auto-merge it once CI is green. Read and follow https://github.com/hivecommons/hive/blob/HEAD/AGENTS.md before changing code.
    

    Prefer not to drive the loop by hand? Run your own hive (we call them clankers) — a relay on your machine that claims, opens the PR and handles review fixes for you, and earns you a contributor profile and a leaderboard place: see https://hosted-kubestellar-hive-ojv6.hive.hivecommons.dev/contribute.

    If nobody claims it, hive may pick it up itself — claiming first prevents that. Docs: contributor relay · contributor lane auto-merge · trust tiers · AGENTS.md.

  6. added
    good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    stage/010-actionableTriaged; eligible for the hive to pick up
    on Nov 4, 2026
  7. hivecommons-hive commented on Nov 4, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #16541 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.

  8. hivecommons-hive commented on Nov 4, 2026

    @hivecommons-hive
    ContributorAuthor

    Not reproducible on v5 — the utility is defined and served.

    • src/pkg/dashboard/static/components.css:813 → .mt-3 { margin-top: var(--sp-3); } (part of the ADR-0018 shared recipe sheet alongside .mt-1….mt-6).
    • src/pkg/dashboard/static-src/head.html:15 → <link rel="stylesheet" href="/components.css">, so every dashboard page loads it.

    The review only searched static-src/css/; the utilities live in the standalone static/components.css sheet, which is why they were not found there. The class="config-field mt-3" fields in config-features.js render with a --sp-3 top margin as intended. Closing as not planned.


    🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

    — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agentgood first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions