Skip to content

[reviewer] Review backlog (correctness): New test largely duplicates TestAdoptNowTakesOverOwnerAuthoredPR #16538

Closed

Description

@hivecommons-hive

Blocked on PR #16495. This finding came from reviewing PR #16495 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #16495.

PR: #16495 (#16495)
Perspective: correctness
Severity: info (P3)
Finding: New test largely duplicates TestAdoptNowTakesOverOwnerAuthoredPR
Evidence: src/pkg/github/automerge/automerge_adopt_now_test.go:168

// parked at 072 when the forced adoption lands.

TestAdoptNowConsumesSupersedeLabelOn072 (automerge_adopt_now_test.go:168-190) repeats the setup and supersede assertion of TestAdoptNowTakesOverOwnerAuthoredPR (:118-161); the only new coverage is the containsLabel(h.api.removed, "adoption/supersede") check at :187. A one-line assertion in the existing test would pin the same behaviour with less duplicated fixture. Advisory only; not a defect.

Fingerprint: b17e242ed3863e0ce68e18cb4efd052679c840e5f03aa2fa69ef892e34722389

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 4, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 4, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 4, 2026
  4. hivecommons-hive commented on Nov 4, 2026

    @hivecommons-hive
    ContributorAuthor

    Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

    Unblocked: #16495 is no longer open. This issue is actionable again.

  5. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 4, 2026
  6. hivecommons-hive commented on Nov 4, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #16495 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.

  7. added
    stage/020-claimedClaimed by the scanner or a relay contributor
    and removed
    stage/010-actionableTriaged; eligible for the hive to pick up
    on Nov 4, 2026
  8. hivecommons-hive commented on Nov 4, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by agent scanner released (holding agent relaunched).

    Claim history
    • 2026-11-04 04:39 UTC — claimed by scanner (agent on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-04 05:15 UTC — released by scanner (agent; holding agent relaunched)
  9. added a commit that references this issue on Nov 4, 2026
    7060ac6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions