Skip to content

🐛 Activity Monitor: PR in progress chevron stays empty while review requests changes; no evidence-based remediation state #16525

Closed

Description

@clubanderson

What the operator saw

Six hive PRs in stage 070 with the Review chevron red (Review 5/5 · changes requested) and CI mostly green (CI 11/11 passed) showed an empty PR in progress chevron (just the branch glyph). Only the one person-owned PR (072) showed a word there (Waiting for @author · not observed coding). Operator: "if review is requesting changes — when will we see a remediating chevron in the PR in progress lane? … That's when we should switch to Remediating — when we KNOW remediation is happening."

Why

stageTrackerApplyCodeActivity (src/pkg/dashboard/stage_tracker_activity.go):

  1. waiting_fixer (070, no fix dispatch observed) sets DisplayColumn = 50 (CI / Review), so the 030/040 column renders as a passed step with no word.
  2. The persistent recorded-push marker overrides everything to pushed / "New head pushed · CI and re-review" even when the changes-requested review landed after that push — i.e. the recorded push is the reviewed head, not a fix. Live: ✨ feat(github): enforce pin-only exception in merge-request relay #16456 push 18:59Z, review red 19:10Z; ✨ feat(dashboard): changed-paragraph reader kiosk view (part 1/3) #16492 push 01:11Z, red 02:06Z; 🌱 test(automerge): pin that a consumed forced adoption drops the adoption/supersede label #16495 push 01:48Z, red 02:21Z — all three read "push seen Nh ago → CI/re-review queued".
  3. Nothing in the payload tells the UI whether anybody has picked the red PR up (hive fix kick running, contributor clanker claim, author push after the ask), so the UI can neither say "Remediating · scanner" nor truthfully say "unassigned".

Expected (binding operator refinement)

Never infer "Remediating" from "review is red". The PR in progress chevron on a red PR must be:

  • Changes requested · unassigned · next: scanner (or CI failing · …, · fixer queued, 3 ahead · next: @bob's clanker when a relay fix is queued) — bright, still, tooltip says what triggers pickup.
  • Remediating · <actor> · <age> — pulsing — only on concrete evidence: (kick) a fix dispatch for this head / a working hive agent whose current action is on the PR since the red signal / a hive-agent claim-ledger claim since then; (claim) the contributor relay holds the fix task or a clanker claim landed since then; (push) a head pushed after the red signal.
  • Fix pushed abc1234 · re-review pending (or · CI pending) — done-style — once the fix head is up.
  • Person-owned 071/072 keep Waiting for @author · changes requested.
  • API: remediation: {actor, kind: kick|claim|push|comment, since, source} on the item; evidence kind + timestamp in the tooltip.

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 4, 2026
  2. github-actions commented on Nov 4, 2026

    @github-actions
    Contributor

    @clubanderson this issue was closed by @hivecommons-hive[bot] as completed.

    If this was closed by a merged PR, the fix only takes effect once it ships in a tagged release and your deployment updates to it — check your running version against the fix before concluding the fix failed.

    If you are still seeing the problem, comment /reopen and it will be reopened for you — you do not need write access. Please add what you are still observing (running version, logs, steps) so it is not closed the same way again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinghelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions