Skip to content

[reviewer] Review backlog (style): SetMatrixPersistPath kept as a no-op stub with no remaining production caller #16517

Closed

Description

@hivecommons-hive

Blocked on PR #16513. This finding came from reviewing PR #16513 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #16513.

PR: #16513 (#16513)
Perspective: style
Severity: low (P3)
Finding: SetMatrixPersistPath kept as a no-op stub with no remaining production caller
Evidence: src/pkg/dashboard/matrix_source.go:482

func (s *Server) SetMatrixPersistPath(_ string) {}

matrix_source.go:482 retains SetMatrixPersistPath as a deprecated no-op 'for callers compiled against the Matrix prototype', but this PR removes its only production caller in cmd/hive/main.go; the only remaining caller is matrix_persist_test.go:22,38,44. Dead exported API within a single module; delete it (part-3 retirement of the Matrix entry point is the natural place).

Fingerprint: 6390d176b9323087f61a1b01851eace3e65c41131ab85eb04464fd2ac8cec2ca

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 4, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 4, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 4, 2026
  4. hivecommons-hive commented on Nov 4, 2026

    @hivecommons-hive
    ContributorAuthor

    Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

    Unblocked: #16513 is no longer open. This issue is actionable again.

  5. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 4, 2026
  6. hivecommons-hive commented on Nov 4, 2026

    @hivecommons-hive
    ContributorAuthor

    Closed as completed: #16513 merged and SetMatrixPersistPath is no longer in src/pkg/dashboard/matrix_source.go on v5, so this finding no longer applies. Reopen if it does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions