Skip to content

[reviewer] Review backlog (correctness): Consumed forced adoption leaves the adopt-supersede label, so the refusal log keeps firing per sweep #16489

Closed

Description

@hivecommons-hive

Blocked on PR #16483. This finding came from reviewing PR #16483 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #16483.

PR: #16483 (#16483)
Perspective: correctness
Severity: info (P3)
Finding: Consumed forced adoption leaves the adopt-supersede label, so the refusal log keeps firing per sweep
Evidence: src/pkg/github/automerge/automerge_contributor_adopt.go:609

if !ok || obs.Author == "" || obs.BaseRef == "" {

The handler adds delegatedecision.LabelAdoptSupersede when queuing Adopt now; after ClearAdoptionForced the label remains, requested stays true (line 609), and every sweep still takes the personAuthored branch and logs the refusal (line 659) with forced=false. Pre-existing behaviour of the requested path; the row itself correctly reads author-owned.

Fingerprint: bdc343514c2fcdcbebcf54e6aaaeb6c5221db933e154972ca9ff6d7f95fd87fc

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 4, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 4, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 4, 2026
  4. hivecommons-hive commented on Nov 4, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #16483 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.

  5. hivecommons-hive commented on Nov 4, 2026

    @hivecommons-hive
    ContributorAuthor

    Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

    Unblocked: #16483 is no longer open. This issue is actionable again.

  6. hivecommons-hive commented on Nov 4, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by agent scanner released (holding agent relaunched).

    Claim history
    • 2026-11-04 00:55 UTC — claimed by scanner (agent on hive hosted-available-oke-11-placeholder-r05x)
    • 2026-11-04 01:28 UTC — released by scanner (agent; holding agent relaunched)
  7. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions