Skip to content

[reviewer] Review backlog (style): integration-materialize.test.cjs fixture has the same gc/rmSync race shape #16414

Closed

Description

@hivecommons-hive

Filed from an out-of-scope finding in the Hive review of PR #16412.

PR: #16412 (#16412)
Perspective: style
Severity: low (P3)
Finding: integration-materialize.test.cjs fixture has the same gc/rmSync race shape
Evidence: .github/scripts/integration-materialize.test.cjs:345

fs.rmSync(directory, {recursive: true});

The sibling materialize contract test builds a throwaway repo under process.cwd() (line 280), runs four git commits through a per-call -c core.hooksPath=/dev/null wrapper that does not set gc.auto=0/maintenance.auto=false (line 290), and tears down with fs.rmSync(directory, {recursive: true}) with no maxRetries/retryDelay (line 345). That is the identical background-git gc --auto vs recursive-remove race this PR fixes in integration-governance.test.cjs:87/:149. The random .integration-contract-<hex> suffix means a leftover will not poison the next run, but the current run can still fail with ENOTEMPTY. Follow-up: apply the same two -c flags and rmSync retry options there.

Fingerprint: 2b0808afae3297baf87a994cb747d038e834e11749367a7f4e3b0a5f7d165e19

filed by Hive review backlog

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 3, 2026
  2. hivecommons-hive commented on Nov 3, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions