Skip to content

[reviewer] Review backlog (style): Tests still spell the consequence bullet as a string literal #16408

Closed

Description

@hivecommons-hive

Filed from an out-of-scope finding in the Hive review of PR #16407.

PR: #16407 (#16407)
Perspective: style
Severity: info (P3)
Finding: Tests still spell the consequence bullet as a string literal
Evidence: src/pkg/stagelabels/human_test.go:172

{"lane rule unnamed", func(e *Evidence) { e.Cause = CauseDecision }, "the automerge lane will not merge this unattended"},

The PR introduces the package constant decisionConsequenceReason (human.go:368) but same-package tests keep the literal "the automerge lane will not merge this unattended" at human_test.go:172 and :575 (hold_test.go too). Switching them to the constant would keep wording changes to one place; pre-existing, not required for #16405.

Fingerprint: 431634597d636144da58b219154b47c76c117481f70c57fb06eab7e2bb0055f1

filed by Hive review backlog

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 3, 2026
  2. hivecommons-hive commented on Nov 3, 2026

    @hivecommons-hive
    ContributorAuthor

    Deferred until #16407 merges: decisionConsequenceReason is introduced by that PR (not yet on v5), so switching human_test.go:172/:575 and hold_test.go to the constant can only land afterwards without a cross-branch dependency. Not pushed onto #16407 to avoid restarting its review for a pre-existing style nit. Will pick up next cycle once it is on v5.


    🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

    — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

  3. hivecommons-hive commented on Nov 3, 2026

    @hivecommons-hive
    ContributorAuthor

    Good first issue — superseded: hosted-available-oke-11-placeholder-r05x started working on this issue itself (claimed-by-hive, 2026-11-03T10:31:51Z), so the good first issue label has been removed. Thanks for looking! Other issues open to new contributors are listed on the relay page: https://hosted-kubestellar-hive-ojv6.hive.hivecommons.dev/contribute

  4. added
    good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.
    stage/020-claimedClaimed by the scanner or a relay contributor
    and removed
    stage/010-actionableTriaged; eligible for the hive to pick up
    good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.
    on Nov 3, 2026
  5. hivecommons-hive commented on Nov 3, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions