You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[reviewer] Review backlog (style): Third inline copy of PR commit pagination #16401
Blocked on PR #16400. This finding came from reviewing PR #16400 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.
Filed from an out-of-scope finding in the Hive review of PR #16400.
PR: #16400 (#16400)
Perspective: style
Severity: info (P3)
Finding: Third inline copy of PR commit pagination
Evidence: src/pkg/github/automerge/automerge_human_paths.go:143
pinOnlyCommitsTrusted (src/pkg/github/automerge/automerge_human_paths.go:143-160) hand-rolls the 3-page ListCommits loop that already exists as pkg/github.(*Client).listPRRepositoryCommits (src/pkg/github/pr_commits.go:100-120, unexported) and in automerge_stage_dco.go:107-119. It matches the in-package idiom and the fail-closed-at-cap behaviour is deliberately stricter than the DCO loop, so this is not blocking; a later refactor could export the pkg/github helper (it already preserves signature verification per its doc comment) and have both automerge callers consume it.
Unblocked: #16400 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
Good first issue — superseded: hosted-available-oke-11-placeholder-r05x started working on this issue itself (claimed-by-hive, 2026-11-03T16:10:57Z), so the good first issue label has been removed. Thanks for looking! Other issues open to new contributors are listed on the relay page: https://hosted-kubestellar-hive-ojv6.hive.hivecommons.dev/contribute
🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.
Activity
hivecommons-hive commentedon Nov 3, 2026
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.
Unblocked: #16400 is no longer open. This issue is actionable again.
hivecommons-hive commentedon Nov 3, 2026
Unblocked: #16400 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
hivecommons-hive commentedon Nov 3, 2026
Good first issue— superseded: hosted-available-oke-11-placeholder-r05x started working on this issue itself (claimed-by-hive, 2026-11-03T16:10:57Z), so thegood first issuelabel has been removed. Thanks for looking! Other issues open to new contributors are listed on the relay page: https://hosted-kubestellar-hive-ojv6.hive.hivecommons.dev/contributehivecommons-hive commentedon Nov 3, 2026
🔒 Claimed by agent
scanner(agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply/unclaimto release, or/claimto take it over if you outrank the holder.hivecommons-hive commentedon Nov 3, 2026
🔓 Claim by agent
scannerreleased (holding agent relaunched).hivecommons-hive commentedon Nov 3, 2026
Fixed by #16435 (merged db58e1a). Closing. Reply /reopen if the problem persists.