You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[reviewer] Review backlog (intent-alignment): Normal-mode stage-note create remains a raw go-github CreateComment #16393
Blocked on PR #16351. This finding came from reviewing PR #16351 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.
Filed from an out-of-scope finding in the Hive review of PR #16351.
PR: #16351 (#16351)
Perspective: intent-alignment
Severity: low (P3)
Finding: Normal-mode stage-note create remains a raw go-github CreateComment
Evidence: src/pkg/github/automerge/automerge_stage_labels.go:1493
Engine.writeStageNote's non-quiet branch (automerge_stage_labels.go:1493) still calls c.gh.Issues.CreateComment directly, so a notifying stage-note comment in notifications.mode=normal bypasses the canary gate / effects journal in Client.CreateIssueComment (client.go:2945) and is counted only in the raw baseline (direct-writes-baseline.txt: automerge_stage_labels.go 4). Issue #16344 scoped the fix to engineStatusForge.CreateComment only, so this is pre-existing and adjacent; a follow-up could route it through the same issueCommenter primitive.
Same file as #16344: both cite src/pkg/github/automerge/automerge_stage_labels.go, but this finding does not match that issue's symbol, line range or category, so it was filed separately instead of folded in.
🔒 Claimed by @thatguywob (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.
Unblocked: #16351 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
@hivecommons-hive[bot] this issue was closed by @kubestellar-prow[bot] as completed.
If this was closed by a merged PR, the fix only takes effect once it ships in a tagged release and your deployment updates to it — check your running version against the fix before concluding the fix failed.
If you are still seeing the problem, comment /reopen and it will be reopened for you — you do not need write access. Please add what you are still observing (running version, logs, steps) so it is not closed the same way again.
Activity
hivecommons-hive commentedon Nov 3, 2026
Same file as #16344: both cite
src/pkg/github/automerge/automerge_stage_labels.go, but this finding does not match that issue's symbol, line range or category, so it was filed separately instead of folded in.filed by Hive review backlog
hivecommons-hive commentedon Nov 3, 2026
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.
Unblocked: #16351 is no longer open. This issue is actionable again.
hivecommons-hive commentedon Nov 3, 2026
🔒 Claimed by @thatguywob (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply
/unclaimto release, or/claimto take it over if you outrank the holder.hivecommons-hive commentedon Nov 3, 2026
🔓 Claim by @thatguywob released (lease revoked).
hivecommons-hive commentedon Nov 3, 2026
Unblocked: #16351 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
🐛 fix(automerge): share stage-note comment adapter
🐛 fix(automerge): align notification inventory with shared adapter
🐛 fix(automerge): gate normal-mode stage-note comments (#16396)
github-actions commentedon Nov 3, 2026
@hivecommons-hive[bot] this issue was closed by @kubestellar-prow[bot] as completed.
If this was closed by a merged PR, the fix only takes effect once it ships in a tagged release and your deployment updates to it — check your running version against the fix before concluding the fix failed.
If you are still seeing the problem, comment
/reopenand it will be reopened for you — you do not need write access. Please add what you are still observing (running version, logs, steps) so it is not closed the same way again.