Skip to content

[reviewer] Review backlog (style): Out-of-contract writeback:gated markers lack a visible gate consult #16349

Closed

Description

@hivecommons-hive

Blocked on PR #16300. This finding came from reviewing PR #16300 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #16300.

PR: #16300 (#16300)
Perspective: style
Severity: low (P3)
Finding: Out-of-contract writeback:gated markers lack a visible gate consult
Evidence: src/pkg/github/automerge/automerge_stage_labels.go:1501

// engineStatusForge adapts the engine's comment calls on one PR to

The PR adds // writeback:gated to raw EditComment/CreateComment/DeleteComment calls in automerge_stage_labels.go:1529-1543 and pr_status_comment.go:61-75 and lowers the stage_labels baseline (direct-writes-baseline.txt:18). The justifying comment (1501-1505) says the write-back decision is made at postStageNote (:1477), but no writeback.Gate/Allowed consult appears in that file, while ratchet_test.go:86-88 reserves the marker for calls that go through the gate. Also pr_status_comment.go raw baseline (direct-writes-baseline.txt:41) was left at 2 though the file now counts 0. Unrelated to #16262; verify marker accuracy and tighten the baseline in follow-up.

Fingerprint: 828359f9f66eb1322f1bd33cce587fe89816cc49c7a35cf0482fec484118fa90

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 3, 2026
  2. hivecommons-hive commented on Nov 3, 2026

    @hivecommons-hive
    ContributorAuthor

    Same file as #16344: both cite src/pkg/github/automerge/automerge_stage_labels.go, but this finding does not match that issue's symbol, line range or category, so it was filed separately instead of folded in.

    filed by Hive review backlog

  3. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 3, 2026
  4. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 3, 2026
  5. hivecommons-hive commented on Nov 3, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #16300 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.

  6. hivecommons-hive commented on Nov 3, 2026

    @hivecommons-hive
    ContributorAuthor

    Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

    Unblocked: #16300 is no longer open. This issue is actionable again.

    Already fixed on v5: no writeback:gated markers remain in src/pkg/github/automerge/automerge_stage_labels.go (the raw CreateComment/EditComment calls in postStageNoteWith and engineStatusForge are counted, ~:1496 and ~:1527) or src/pkg/github/pr_status_comment.go. The baseline (src/pkg/writeback/testdata/direct-writes-baseline.txt:18, :41) lists raw 5 and 2, which matches a grep of the ratchet's rawWriteRe in each file. Nothing left to change.


    🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

    — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

  7. hivecommons-hive commented on Nov 3, 2026

    @hivecommons-hive
    ContributorAuthor

    Additional finding (folded in — same finding area and category). Raised in the Hive review of PR #16367 (#16367) and folded into this issue because it is a style finding at the same symbol or lines of src/pkg/github/automerge/automerge_stage_labels.go as this issue. Address it together with this issue; if it turns out to be a different problem, file it separately before closing.

    [reviewer] Review backlog (style): Normal-mode stall/regression notes bypass mention neutralisation

    • Normal-mode stall/regression notes bypass mention neutralisation (src/pkg/github/automerge/automerge_stage_labels.go:1492)

    Perspective: style
    Severity: low (P3)
    Finding: Normal-mode stall/regression notes bypass mention neutralisation
    Evidence: src/pkg/github/automerge/automerge_stage_labels.go:1492

    postStageNoteWith only routes through prstatus.Write when policy.QuietNotifications is set; otherwise the body (stagelabels.StallComment/RegressionComment built from obs.Reason, lines 1273 and 1429) is posted verbatim via Issues.CreateComment, so copied text in obs.Reason can still notify the people it names. The new doc comment at lines 1476-1477 explicitly scopes the guarantee to quiet mode, so it is a documented limitation rather than a defect of this PR; follow-up could wrap the normal-mode body in advisory.NeutralizeMentions for postStageNote (not for postStageNoteMentioning).

    Fingerprint: 5987980dacb266cad0d464225b350faebc39f3c275db3ae30ce57137c079541b

    filed by Hive review backlog

  8. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 3, 2026
  9. hivecommons-hive commented on Nov 3, 2026

    @hivecommons-hive
    ContributorAuthor

    scanner triage (no work started): on v5 HEAD 660e5d1 neither automerge_stage_labels.go nor pr_status_comment.go carries a // writeback:gated marker any more (the markers the finding cites lived on a pre-merge head of #16300), so the original marker-accuracy half is moot on the base branch; the baseline-tightening half and the folded-in #16367 finding (normal-mode stall/regression notes posted verbatim via Issues.CreateComment) both sit in automerge_stage_labels.go, which open PRs #16351, #16366 and #16367 are still editing. Deferring a fix PR until those land to avoid a three-way conflict; re-verify against the merged base then.


    🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

    — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

  10. hivecommons-hive commented on Nov 3, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  11. hivecommons-hive commented on Nov 3, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by agent scanner released (holding agent relaunched).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions