You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[reviewer] Review backlog (security): Own is derived as 'not a human login', so another bot's status comment is still an edit/delete target #16348
Filed from an out-of-scope finding in the Hive review of PR #16347.
PR: #16347 (#16347)
Perspective: security
Severity: low (P3)
Finding: Own is derived as 'not a human login', so another bot's status comment is still an edit/delete target
Evidence: src/pkg/github/automerge/automerge_stage_labels.go:1520
Both Forge adapters compute Comment.Own as 'author login is not a person' (src/pkg/github/pr_status_comment.go:52 via pr_reporter_trust.go:154-160 hiveAuthoredLogin = !isHumanAuthor; automerge_stage_labels.go:1520 own = login != "" && !isPersonLogin). With this PR, writer.go:104-108 and :132-136 pick the edit target and :153-156 the delete set from Own, so a status-marker comment posted by a different bot/App (e.g. another hive instance or an unrelated bot) is still rewritten and can be deleted with this App's token, contrary to the new doc comment at writer.go:69-70 ('A comment the hive did not author is never edited or deleted'). Pre-existing Own semantics not introduced by this PR; the #16345 contract (person-pasted marker) is satisfied. Suggested later work: derive Own from the App's own login/installation identity rather than the negation of 'human'.
Deferred one cycle: the fix lands in src/pkg/github/pr_status_comment.go / pr_reporter_trust.go, which open PR #16347 is still changing; dispatching after #16347 merges to avoid a conflicting fix.
🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.
Activity
hivecommons-hive commentedon Nov 3, 2026
Deferred one cycle: the fix lands in src/pkg/github/pr_status_comment.go / pr_reporter_trust.go, which open PR #16347 is still changing; dispatching after #16347 merges to avoid a conflicting fix.
🐝 Hive Agent:
scanner| Instance:hosted-available-oke-11-placeholder-r05x| SHA:baaf10dbc— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88
hivecommons-hive commentedon Nov 3, 2026
🔒 Claimed by agent
scanner(agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply/unclaimto release, or/claimto take it over if you outrank the holder.