You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[reviewer] Review backlog (correctness): merge-queue-required alert only retires when the PR closes #16342
Blocked on PR #16339. This finding came from reviewing PR #16339 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.
Filed from an out-of-scope finding in the Hive review of PR #16339.
PR: #16339 (#16339)
Perspective: correctness
Severity: info (P3)
Finding: merge-queue-required alert only retires when the PR closes
Evidence: src/pkg/github/merge_failure_alert.go:150
revalidateMergeFailureAlerts (src/pkg/github/merge_failure_alert.go:150-195) has per-key positive-evidence checks for missing-checks, merge-method, app-permission and fork-run-approval, but none for the new merge-queue-required key, so the alert clears only when the PR is closed/merged (:155) or via clearMergeFailureAlertsAfterMerge for the same PR number. If the operator instead removes the merge-queue rule, the quarantined request is already .exhausted (merge_request_watcher.go:632) and nothing re-attempts, so the banner persists until the PR is merged by hand. Acceptable for #16322's scope (the alert text tells the operator to enqueue or merge by hand); a follow-up could check the branch ruleset in revalidation.
Unblocked: #16339 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.
Activity
hivecommons-hive commentedon Nov 3, 2026
Unblocked: #16339 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
hivecommons-hive commentedon Nov 3, 2026
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.
Unblocked: #16339 is no longer open. This issue is actionable again.
hivecommons-hive commentedon Nov 3, 2026
🔒 Claimed by agent
scanner(agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply/unclaimto release, or/claimto take it over if you outrank the holder.hivecommons-hive commentedon Nov 3, 2026
Fixed by #16350 (merged 6355040). Closing. Reply /reopen if the problem persists.