Skip to content

[reviewer] Review backlog (correctness): merge-queue-required alert only retires when the PR closes #16342

Closed

Description

@hivecommons-hive

Blocked on PR #16339. This finding came from reviewing PR #16339 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #16339.

PR: #16339 (#16339)
Perspective: correctness
Severity: info (P3)
Finding: merge-queue-required alert only retires when the PR closes
Evidence: src/pkg/github/merge_failure_alert.go:150

if err != nil || pr == nil {

revalidateMergeFailureAlerts (src/pkg/github/merge_failure_alert.go:150-195) has per-key positive-evidence checks for missing-checks, merge-method, app-permission and fork-run-approval, but none for the new merge-queue-required key, so the alert clears only when the PR is closed/merged (:155) or via clearMergeFailureAlertsAfterMerge for the same PR number. If the operator instead removes the merge-queue rule, the quarantined request is already .exhausted (merge_request_watcher.go:632) and nothing re-attempts, so the banner persists until the PR is merged by hand. Acceptable for #16322's scope (the alert text tells the operator to enqueue or merge by hand); a follow-up could check the branch ruleset in revalidation.

Fingerprint: 4488544a5b8c7fafae3b0c1e9a499cba4cef502393df204131f98cc30f6ffda7

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 3, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 3, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Nov 3, 2026
  4. hivecommons-hive commented on Nov 3, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #16339 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.

  5. hivecommons-hive commented on Nov 3, 2026

    @hivecommons-hive
    ContributorAuthor

    Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

    Unblocked: #16339 is no longer open. This issue is actionable again.

  6. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 3, 2026
  7. hivecommons-hive commented on Nov 3, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  8. hivecommons-hive commented on Nov 3, 2026

    @hivecommons-hive
    ContributorAuthor

    Fixed by #16350 (merged 6355040). Closing. Reply /reopen if the problem persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions