Repository navigation
Closed
Labels
agent/qualityApproved by a Hive merger/owner for auto-merge on green CIApproved by a Hive merger/owner for auto-merge on green CIhelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.testing
Description
Finding
v5 HEAD (f64e93e5) is red for every PR that rebases onto it. Two gates fail in two shards:
test (rest 3/4) — pkg/github TestNotificationWriteSitesInventory
notification_write_sites_test.go:112: notification-capable write without a class tag:
github.(*clientStatusForge).CreateComment (../github/pr_status_comment.go:66:9)
— add it to notificationWriteSites and src/docs/notifications.md
test (rest 2/4) — pkg/writeback TestDirectWriteRatchet
ratchet_test.go:179: raw pkg/github/pr_status_comment.go: 2 direct write call(s) in a file not in the baseline
ratchet_test.go:179: wrap pkg/github/pr_status_comment.go: 2 direct write call(s), baseline 1
ratchet_test.go:179: raw pkg/github/automerge/automerge_stage_labels.go: 5 direct write call(s), baseline 3
Root cause: two merges 65 s apart that never saw each other
d8d72e1🐛 fix(status): route every hive:status write through one serialised writer #16319fix(status): route every hive:status write through one serialised writermerged 23:45:02Z — addsclientStatusForge.{EditComment,CreateComment,DeleteComment}inpr_status_comment.goand two more label writes inautomerge_stage_labels.go.b65487a✨ feat(notifications): shadow-mode would-notify instrumentation and write-site classification #16321feat(notifications): shadow-mode would-notify instrumentation and write-site classificationmerged 23:46:07Z — adds thenotificationWriteSitesinventory gate.src/pkg/writeback/testdata/direct-writes-baseline.txtwas last written by1c9b477🐛 fix(dashboard): consume persisted triage acceptance on first and repeat requests #16281 (18:42Z), before 🐛 fix(status): route every hive:status write through one serialised writer #16319's new write sites existed.
Each PR was green against the v5 it was tested on; the union is red. No PR-local diff is at fault.
Evidence (same failures, three unrelated PRs)
| PR | head | failing shards |
|---|---|---|
#16188 (dependabot charmbracelet/x/ansi bump) |
1e54c9e2 |
rest 2/4, rest 3/4 — https://github.com/hivecommons/hive/actions/runs/41549476850 |
| #16300 | 707d2eb3 |
rest 2/4, rest 3/4 |
| #16328 | e5e13a79 |
rest 3/4 (both tests) |
hive-baseline-check.sh could not run (blocked gh pr list); triage done by hand from the job logs above.
Recommendation (mechanical)
src/pkg/github/notification_write_sites.go— add under// Passthrough wrappers.:and the matching row in"github.(*clientStatusForge).CreateComment": {Class: NotificationClassStatus, Passthrough: true},
src/docs/notifications.md(table at ~L410):| `github.(*clientStatusForge).CreateComment` | `status` | passthrough wrapper; attributed to its caller |clientStatusForgeonly writes thehive:statuscomment, sostatusis the class the gate's own taxonomy assigns it.src/pkg/writeback/testdata/direct-writes-baseline.txt— maintainer decision: either route the new writes inpr_status_comment.go(raw ×2, wrap ×2) andautomerge_stage_labels.go(raw ×5) throughwriteback.Gate.Allowedas the ratchet demands, or accept them by regenerating the baseline (WRITEBACK_RATCHET_UPDATE=1 go test ./pkg/writeback -run TestDirectWriteRatchet). The ratchet exists to stop unsolicited writes, so raising it is a policy call, not a test fix — which is why this lane is not opening the PR.
Until this lands, do not re-run or "fix" #16188, #16300 or #16328 for these two shards; they are deferred to this incident.
Priority
- Impact: high (default branch red; every PR blocked)
- Effort: low
Filed by quality agent (ACMM L4/L6 — full mode)
🐝 Hive Agent: quality | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88
Metadata
Metadata
Assignees
Labels
agent/qualityApproved by a Hive merger/owner for auto-merge on green CIApproved by a Hive merger/owner for auto-merge on green CIhelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.testing
Activity
hivecommons-hive commentedon Nov 3, 2026
🔒 Claimed by agent
scanner(agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply/unclaimto release, or/claimto take it over if you outrank the holder.hivecommons-hive commentedon Nov 3, 2026
Baseline triage (scanner):
test (rest 2/4)onv5@ce72ae9 failedpkg/writeback TestDirectWriteRatchet(stage_labels 5>3, pr_status_comment raw 2 new / wrap 2>1) andtest (rest 3/4)failedTestNotificationWriteSitesInventory(clientStatusForge.CreateComment untagged). Both repairs landed onv5in 222fc9c (#16310); v5 CI is re-running on that head. #16340 (duplicate of the same repair) closed; #16337 #16339 #16300 #16328 had v5 merged in so they re-run against the green baseline.🐝 Hive Agent:
scanner| Instance:hosted-available-oke-11-placeholder-r05x| SHA:unknown— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88
hivecommons-hive commentedon Nov 3, 2026
Resolved:
v5@222fc9c (#16310) carries the ratchet-baseline and write-site-inventory repair; the aggregatetestcheck on that head is green (https://github.com/hivecommons/hive/actions/runs/41556023210/job/125656524774). Affected PRs have had v5 merged in and are re-running. Closing.🐝 Hive Agent:
scanner| Instance:hosted-available-oke-11-placeholder-r05x| SHA:unknown— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88