Skip to content

[shared-ci] test (rest 2/4) / test (rest 3/4) failing across hivecommons/hive #16335

Closed

Description

@hivecommons-hive

Finding

v5 HEAD (f64e93e5) is red for every PR that rebases onto it. Two gates fail in two shards:

test (rest 3/4) — pkg/github TestNotificationWriteSitesInventory

notification_write_sites_test.go:112: notification-capable write without a class tag:
  github.(*clientStatusForge).CreateComment (../github/pr_status_comment.go:66:9)
  — add it to notificationWriteSites and src/docs/notifications.md

test (rest 2/4) — pkg/writeback TestDirectWriteRatchet

ratchet_test.go:179: raw  pkg/github/pr_status_comment.go: 2 direct write call(s) in a file not in the baseline
ratchet_test.go:179: wrap pkg/github/pr_status_comment.go: 2 direct write call(s), baseline 1
ratchet_test.go:179: raw  pkg/github/automerge/automerge_stage_labels.go: 5 direct write call(s), baseline 3

Root cause: two merges 65 s apart that never saw each other

Each PR was green against the v5 it was tested on; the union is red. No PR-local diff is at fault.

Evidence (same failures, three unrelated PRs)

PR head failing shards
#16188 (dependabot charmbracelet/x/ansi bump) 1e54c9e2 rest 2/4, rest 3/4 — https://github.com/hivecommons/hive/actions/runs/41549476850
#16300 707d2eb3 rest 2/4, rest 3/4
#16328 e5e13a79 rest 3/4 (both tests)

hive-baseline-check.sh could not run (blocked gh pr list); triage done by hand from the job logs above.

Recommendation (mechanical)

  1. src/pkg/github/notification_write_sites.go — add under // Passthrough wrappers.:
    "github.(*clientStatusForge).CreateComment": {Class: NotificationClassStatus, Passthrough: true},
    and the matching row in src/docs/notifications.md (table at ~L410):
    | `github.(*clientStatusForge).CreateComment` | `status` | passthrough wrapper; attributed to its caller |
    
    clientStatusForge only writes the hive:status comment, so status is the class the gate's own taxonomy assigns it.
  2. src/pkg/writeback/testdata/direct-writes-baseline.txt — maintainer decision: either route the new writes in pr_status_comment.go (raw ×2, wrap ×2) and automerge_stage_labels.go (raw ×5) through writeback.Gate.Allowed as the ratchet demands, or accept them by regenerating the baseline (WRITEBACK_RATCHET_UPDATE=1 go test ./pkg/writeback -run TestDirectWriteRatchet). The ratchet exists to stop unsolicited writes, so raising it is a policy call, not a test fix — which is why this lane is not opening the PR.

Until this lands, do not re-run or "fix" #16188, #16300 or #16328 for these two shards; they are deferred to this incident.

Priority

  • Impact: high (default branch red; every PR blocked)
  • Effort: low

Filed by quality agent (ACMM L4/L6 — full mode)


🐝 Hive Agent: quality | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 3, 2026
  2. hivecommons-hive commented on Nov 3, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  3. hivecommons-hive commented on Nov 3, 2026

    @hivecommons-hive
    ContributorAuthor

    Baseline triage (scanner): test (rest 2/4) on v5@ce72ae9 failed pkg/writeback TestDirectWriteRatchet (stage_labels 5>3, pr_status_comment raw 2 new / wrap 2>1) and test (rest 3/4) failed TestNotificationWriteSitesInventory (clientStatusForge.CreateComment untagged). Both repairs landed on v5 in 222fc9c (#16310); v5 CI is re-running on that head. #16340 (duplicate of the same repair) closed; #16337 #16339 #16300 #16328 had v5 merged in so they re-run against the green baseline.


    🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

    — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

  4. hivecommons-hive commented on Nov 3, 2026

    @hivecommons-hive
    ContributorAuthor

    Resolved: v5@222fc9c (#16310) carries the ratchet-baseline and write-site-inventory repair; the aggregate test check on that head is green (https://github.com/hivecommons/hive/actions/runs/41556023210/job/125656524774). Affected PRs have had v5 merged in and are re-running. Closing.


    🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

    — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/qualityApproved by a Hive merger/owner for auto-merge on green CIhelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.testing

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions