You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[reviewer] Review backlog (docs-currency): github.attention is an opaque leaf for the Settings parity gate; admitter/flap_window are not individually tracked #16331
Filed from an out-of-scope finding in the Hive review of PR #16328.
PR: #16328 (#16328)
Perspective: docs-currency
Severity: low (P3)
Finding: github.attention is an opaque leaf for the Settings parity gate; admitter/flap_window are not individually tracked
Evidence: src/internal/settingsparity/settingsparity.go:48
ConfigLeaves only collects struct decls from pkg/config, crux/config, pkg/dashboard/theme and pkg/writeback (settingsparity.go:48-53); attention.Config (pkg/attention) does not resolve, so the SelectorExpr falls through as a single leaf 'github.attention' (settingsparity.go:111). The allowlist entry at settings_parity_allowlist.txt:195 is therefore valid and the test passes, but unlike github.notifications.mode the sub-keys github.attention.admitter. and github.attention.flap_window will never be enumerated, so a future Settings UI control for one of them would not retire the allowlist entry automatically. Remediation for a follow-up: add filepath.Join("pkg","attention") to the collected dirs (as was done for pkg/writeback) and list the two leaf paths in the allowlist.
@hivecommons-hive[bot] this issue was closed by @clubanderson as completed.
If this was closed by a merged PR, the fix only takes effect once it ships in a tagged release and your deployment updates to it — check your running version against the fix before concluding the fix failed.
If you are still seeing the problem, comment /reopen and it will be reopened for you — you do not need write access. Please add what you are still observing (running version, logs, steps) so it is not closed the same way again.
Activity
🌱 chore(settingsparity): collect pkg/attention so github.attention le…
hivecommons-hive commentedon Nov 3, 2026
Addressed on the #16328 branch in 1d4c0be; closes when #16328 merges.
🐝 Hive Agent:
scanner| Instance:hosted-available-oke-11-placeholder-r05x| SHA:baaf10dbc— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88
hivecommons-hive commentedon Nov 3, 2026
Fixed by #16328 (merged 6a7d185). Closing. Reply /reopen if the problem persists.
github-actions commentedon Nov 3, 2026
@hivecommons-hive[bot] this issue was closed by @clubanderson as completed.
If this was closed by a merged PR, the fix only takes effect once it ships in a tagged release and your deployment updates to it — check your running version against the fix before concluding the fix failed.
If you are still seeing the problem, comment
/reopenand it will be reopened for you — you do not need write access. Please add what you are still observing (running version, logs, steps) so it is not closed the same way again.