Skip to content

🐛 Matrix stream never admits a line: sentinel PatchObserver reports the bare repo slug, so dashboard.matrix.repos never matches #16235

Closed

Description

@clubanderson

Symptom

Hive's spoke with dashboard.matrix.enabled: true, repos: [hivecommons/hive] (/api/status → matrixEnabled: true) shows "Waiting for pushed lines…"; GET /api/matrix/lines stays {"seq":0,"source":"pushed-lines","lines":[]} even after a hive-authored push (#16201 by hivecommons-hive at 14:59Z) and a completed sentinel sweep (sentinel sweep complete seen=13 ...).

Root cause

SweepSentinel iterates c.getRepos(), which holds the configured slugs — bare names such as hive (the sentinel logs show "repo":"hive"). That slug is passed as displayRepo into observeSentinelPatch, which sets SentinelPatchObservation.Repo = displayRepo. matrixSource.admits then calls MatrixConfig.RepoAllowed(obs.Repo), an exact EqualFold against owner/name entries, so "hive" never matches "hivecommons/hive" and every observation is dropped. The same bare slug makes sentinelRepoPrivate fall back to "treat as private" whenever the PR payload lacks base.repo.private.

Fix

Build the observation with the fully qualified owner/name (the sweep already has owner and repo from splitRepo), and use it for the privacy lookup too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    has-open-prhelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.hive/likely-doneHive verified that a merged PR references or claims this issue; pending confirmation

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions