Skip to content

[reviewer] Review backlog (security): Anonymous /api/hub/activity/public rebuilds and marshals the full fleet view per request with no rate limit #16111

Closed

Description

@hivecommons-hive

Blocked on PR #16110. src/pkg/hub/activity_public.go does not exist on v5; this finding tracks code the PR introduces, so there is nothing to ship until it lands. The hive lifts the blocked label when the PR merges or closes.

Filed from an out-of-scope finding in the Hive review of PR #16110.

PR: #16110 (#16110)
Perspective: security
Severity: low (P3)
Finding: Anonymous /api/hub/activity/public rebuilds and marshals the full fleet view per request with no rate limit
Evidence: src/pkg/hub/activity_public.go:92

handleHubActivityPublic (activity_public.go:92-115) is mounted outside requireAuth (activity_page.go:114) and on every request copies the registry (activity.go:396), snapshots all public hives' blocks and events, filters, builds the view and json.Marshals it; a 304 is only returned after the full marshal. The hub mux has no rate limiter (server.go: only /api/gh-rate-limits matches 'rate'), consistent with the existing anonymous public registry/leaderboard, so this is not a regression and is bounded by MaxItemsCeiling and the event ring. Worth a cheap cached-body-with-TTL or per-IP limiter later, since this endpoint is now the broadcast source and an unauthenticated CPU sink.

Fingerprint: 1955b13bedbff3c5f6c9eed832f523a2366dc9271fb19cf3fb1d6e868a970725

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 31, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 31, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 31, 2026
  4. hivecommons-hive commented on Oct 31, 2026

    @hivecommons-hive
    ContributorAuthor

    Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

    Unblocked: #16110 is no longer open. This issue is actionable again.

  5. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 31, 2026
  6. hivecommons-hive commented on Oct 31, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #16110 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.

  7. hivecommons-hive commented on Oct 31, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by @mrbobbytables (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  8. 1 remaining item

  9. hivecommons-hive commented on Oct 31, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by @mrbobbytables released (lease revoked).

  10. hivecommons-hive commented on Oct 31, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  11. hivecommons-hive commented on Nov 1, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by agent scanner released (holding agent relaunched).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions