Skip to content

[reviewer] Review backlog (correctness): Shared row asset's STAGE_TRACKER_* inputs stay spoke-only with no drift guard for the hub #16068

Closed

Description

@hivecommons-hive

Blocked on PR #16066. src/pkg/webassets/trackerrow/trackerrow.go does not exist on v5; this finding tracks code the PR introduces, so there is nothing to ship until it lands. The hive lifts the blocked label when the PR merges or closes.

Filed from an out-of-scope finding in the Hive review of PR #16066.

PR: #16066 (#16066)
Perspective: correctness
Severity: low (P3)
Evidence: src/pkg/webassets/trackerrow/trackerrow.go:14 (

// (tracker-words-core.js and agent-now.js on the spoke) and esc(). The anchor
)
Finding: Shared row asset's STAGE_TRACKER_* inputs stay spoke-only with no drift guard for the hub

tracker-row-anchor.js reads STAGE_TRACKER_PATH, STAGE_TRACKER_TERMINAL, STAGE_TRACKER_PRE_MERGE_SOAK etc. as free globals (src/pkg/webassets/trackerrow/tracker-row-anchor.js:21-48), which are defined only in spoke files (static-src/js/agent-now.js:472, static-src/js/tracker-words-core.js:76,105) and not in the shared module. trackerrow.go:14-16 documents that the host must supply them, but nothing pins the hub's copies to the spoke's values, so #16063 can silently light different columns than the spoke if the constants drift. Consider moving the constants into a shared part (or a Go-side table) when the hub activates the asset. Not a defect of this PR: the spoke artifact is byte-identical and the compat test covers the two files that moved.

Fingerprint: 673e8064a35568c645bf7ad5bc0df7832a40fbed6fbc85d642b16b885cc08068

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 31, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 31, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 31, 2026
  4. hivecommons-hive commented on Oct 31, 2026

    @hivecommons-hive
    ContributorAuthor

    Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

    Unblocked: #16066 is no longer open. This issue is actionable again.

  5. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 31, 2026
  6. hivecommons-hive commented on Oct 31, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #16066 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.

  7. hivecommons-hive commented on Oct 31, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  8. hivecommons-hive commented on Oct 31, 2026

    @hivecommons-hive
    ContributorAuthor

    Fixed by #16081 (merged dc26e91). Closing. Reply /reopen if the problem persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions