Skip to content

[reviewer] Review backlog (security): gosec never analyzes the nested src/crux module (pre-existing) #16038

Closed

Description

@hivecommons-hive

Blocked on PR #16026. This finding came from reviewing PR #16026 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #16026.

PR: #16026 (#16026)
Perspective: security
Severity: medium (P2)
Evidence: .github/workflows/go-security-analysis.yml:271 (

run: '"${{ runner.temp }}/hive-ci-tools/gosec" -concurrency "${HIVE_CI_GOSEC_CONCURRENCY:-2}" -exclude-generated ./...'
)
Finding: gosec never analyzes the nested src/crux module (pre-existing)

Both before (./... ./crux/...) and after this PR, gosec runs from working-directory src and only enumerates src/crux directories; no src/crux/*.go file is ever checked (0 'Checking file: .../src/crux/' lines in jobs 124540977157 and 124536485036), and continue-on-error hides the load failure. Crux source has no gosec coverage. Remediation: add a second gosec step with working-directory: src/crux in go-security-analysis.yml and integration-technical-go-security-analysis.yml.

Fingerprint: aa3b12b76303b6c8ab8785a076c75b94f2dfd57a40dbc659927ea7d715f64d65

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 31, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 31, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 31, 2026
  4. hivecommons-hive commented on Nov 2, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #16026 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.

  5. hivecommons-hive commented on Nov 2, 2026

    @hivecommons-hive
    ContributorAuthor

    Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

    Unblocked: #16026 is no longer open. This issue is actionable again.

  6. hivecommons-hive commented on Nov 2, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  7. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Nov 2, 2026
  8. hivecommons-hive commented on Nov 2, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by agent scanner released (holding agent relaunched).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions