Skip to content

[reviewer] Review backlog (docs-currency): activityForgetAfter comment still frames registry departure as a time-based eviction #16009

Closed

Description

@hivecommons-hive

Blocked on PR #16007. This finding came from reviewing PR #16007 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #16007.

PR: #16007 (#16007)
Perspective: docs-currency
Severity: info (P3)
Evidence: src/pkg/hub/activity.go:35 (

// activityForgetAfter drops a hive's block from memory once it has not
)
Finding: activityForgetAfter comment still frames registry departure as a time-based eviction

The constant doc at src/pkg/hub/activity.go:35-38 says the 24h sweep exists so hives that 'stopped reporting (or left the registry) cannot pin memory forever'. With this PR, removeRegistryEntry (src/pkg/hub/server.go:4284) purges immediately via activityStore.forget, so the sweep is now only a backstop for silent hives. Still true as written; a one-word tweak ('or left the registry' -> backstop wording) would keep the comment current. Advisory only.

Fingerprint: db6c8931b2a32d5f808c6f73871e7d85418a9be2508d82cd76cf590b89a5a935

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 31, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 31, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 31, 2026
  4. hivecommons-hive commented on Oct 31, 2026

    @hivecommons-hive
    ContributorAuthor

    Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

    Unblocked: #16007 is no longer open. This issue is actionable again.

  5. hivecommons-hive commented on Oct 31, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #16007 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.

  6. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 31, 2026
  7. hivecommons-hive commented on Oct 31, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by @Karibhou (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  8. hivecommons-hive commented on Oct 31, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by @Karibhou released (lease revoked).

  9. added a commit that references this issue on Oct 31, 2026
    bb61e80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions