Skip to content

[reviewer] Review backlog (security): activityStore is not purged when a hive is removed from the registry #16002

Closed

Description

@hivecommons-hive

Blocked on PR #16001. src/pkg/hub/activity.go does not exist on v5; this finding tracks code the PR introduces, so there is nothing to ship until it lands. The hive lifts the blocked label when the PR merges or closes.

Filed from an out-of-scope finding in the Hive review of PR #16001.

PR: #16001 (#16001)
Perspective: security
Severity: low (P3)
Evidence: src/pkg/hub/activity.go:117 (

)
Finding: activityStore is not purged when a hive is removed from the registry

activityStore.record/forgetOldLocked (src/pkg/hub/activity.go:72-124) only evicts a hive's digest after activityForgetAfter (24h). handleDeleteHive (src/pkg/hub/saas_hives_api.go:1732) removes the registry entry via removeRegistryEntry but never clears s.activity, so the last digest of a deleted hive stays in hub memory for up to 24h. It is not reachable through GET /api/hub/activity today because visibleActivityHives only yields registry hives (Missing hives skip the block at activity.go:275), and hosted IDs cannot be re-registered by a spoke (server.go:2710). Advisory: call a small activityStore.forget(id) from the registry-removal path so the memory-only retention promise in the PR body also holds on delete, not just on silence.

Fingerprint: 172bba4f2312ab18a4594f5e3e94c9c22b973ad73cf6e4d16abdefd672ea177c

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 31, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 31, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 31, 2026
  4. hivecommons-hive commented on Oct 31, 2026

    @hivecommons-hive
    ContributorAuthor

    Re-targeted: blocker #16001 was superseded by #16005.

  5. removed
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 31, 2026
  6. hivecommons-hive commented on Oct 31, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #16005 is no longer open. This issue is actionable again.

  7. hivecommons-hive commented on Oct 31, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  8. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 31, 2026
  9. added
    stage/010-actionableTriaged; eligible for the hive to pick up
    and removed
    stage/020-claimedClaimed by the scanner or a relay contributor
    on Oct 31, 2026
  10. hivecommons-hive commented on Oct 31, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #16005 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.

  11. hivecommons-hive commented on Oct 31, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by agent scanner released (holding agent relaunched).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions