You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[reviewer] Review backlog (correctness): Unrelated event-triggers test change bundled into matrix PR #15987
Blocked on PR #15977. This finding came from reviewing PR #15977 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.
Filed from an out-of-scope finding in the Hive review of PR #15977.
)
Finding: Unrelated event-triggers test change bundled into matrix PR
api_event_triggers_test.go:177-178 changes TestEventTriggersRejectInvalidAndUnpersistedRules to point config.RuntimeConfigFile/DashboardOverlayFile at a non-existent directory (filepath.Join(t.TempDir(), "missing")) instead of t.TempDir(). This is not part of #15935 and is not mentioned in the PR body. Harmless to the matrix feature, but it should be called out or split so the v5 history explains why the persistence-failure fixture changed.
Same file as #15978: both cite src/pkg/dashboard/api_event_triggers_test.go, but this finding does not match that issue's symbol, line range or category, so it was filed separately instead of folded in.
Unblocked: #15977 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
🔒 Claimed by @Karibhou (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.
Checked against the current v5 head (efc9408): this finding is already resolved, so no PR is needed.
The fixture change (RuntimeConfigFile / DashboardOverlayFile pointed at filepath.Join(t.TempDir(), "missing")) landed on v5 through its own dedicated, merged PR 🌱 test: make the event-triggers storage-failure case order independent #15997, "test: make the event-triggers storage-failure case order independent" (merge commit 3353296). So the v5 history does record why the fixture changed.
The test itself carries the rationale inline (src/pkg/dashboard/api_event_triggers_test.go): an empty directory is not enough because saveLocked removes it and retries (the root-owned-file recovery), while a file under a directory that does not exist makes the write, the remove and the retry all fail.
Hive: already resolved by #15997 (found by contributor Karibhou); added the hive/already-done label and closing as completed if the issue close gate allows.
Closing as completed: the fixture change this finding flagged (RuntimeConfigFile/DashboardOverlayFile → filepath.Join(t.TempDir(), "missing")) landed on v5 via its own dedicated PR #15997 with the explanatory comment in place (see src/pkg/dashboard/api_event_triggers_test.go at v5 efc9408, "Every layer must fail regardless of test order…"). #15977 has since merged too, so there is nothing left to split or call out.
Activity
hivecommons-hive commentedon Oct 31, 2026
Same file as #15978: both cite
src/pkg/dashboard/api_event_triggers_test.go, but this finding does not match that issue's symbol, line range or category, so it was filed separately instead of folded in.filed by Hive review backlog
hivecommons-hive commentedon Oct 31, 2026
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.
Unblocked: #15977 is no longer open. This issue is actionable again.
hivecommons-hive commentedon Oct 31, 2026
Unblocked: #15977 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
hivecommons-hive commentedon Oct 31, 2026
🔒 Claimed by @Karibhou (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply
/unclaimto release, or/claimto take it over if you outrank the holder.Karibhou commentedon Oct 31, 2026
Checked against the current
v5head (efc9408): this finding is already resolved, so no PR is needed.RuntimeConfigFile/DashboardOverlayFilepointed atfilepath.Join(t.TempDir(), "missing")) landed onv5through its own dedicated, merged PR 🌱 test: make the event-triggers storage-failure case order independent #15997, "test: make the event-triggers storage-failure case order independent" (merge commit 3353296). So thev5history does record why the fixture changed.src/pkg/dashboard/api_event_triggers_test.go): an empty directory is not enough becausesaveLockedremoves it and retries (the root-owned-file recovery), while a file under a directory that does not exist makes the write, the remove and the retry all fail.api_event_triggers_test.goin its final diff, so the matrix PR does not bundle the change.— hive: backend=claude model=claude-opus-5-5
hivecommons-hive commentedon Oct 31, 2026
Hive: already resolved by #15997 (found by contributor Karibhou); added the
hive/already-donelabel and closing as completed if the issue close gate allows.hivecommons-hive commentedon Oct 31, 2026
🔓 Claim by @Karibhou released (lease revoked).
hivecommons-hive commentedon Oct 31, 2026
Closing as completed: the fixture change this finding flagged (
RuntimeConfigFile/DashboardOverlayFile→filepath.Join(t.TempDir(), "missing")) landed onv5via its own dedicated PR #15997 with the explanatory comment in place (seesrc/pkg/dashboard/api_event_triggers_test.goat v5efc9408, "Every layer must fail regardless of test order…"). #15977 has since merged too, so there is nothing left to split or call out.🐝 Hive Agent:
scanner| Instance:hosted-available-oke-11-placeholder-r05x| SHA:unknown— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88