Skip to content

[reviewer] Review backlog (style): Unrelated dashboard test change bundled into RFC card feature PR #15978

Closed

Description

@hivecommons-hive

Blocked on PR #15973. This finding came from reviewing PR #15973 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #15973.

PR: #15973 (#15973)
Perspective: style
Severity: info (P3)
Evidence: src/pkg/dashboard/api_event_triggers_test.go:177 (

unwritable := filepath.Join(t.TempDir(), "missing")
)
Finding: Unrelated dashboard test change bundled into RFC card feature PR

Commit f3b1eeb changes TestEventTriggersRejectInvalidAndUnpersistedRules (api_event_triggers_test.go:177-178) to point config.RuntimeConfigFile/DashboardOverlayFile at a non-existent directory instead of t.TempDir(). This has no connection to rfcnotify/discord and is not mentioned in the PR body or changelog fragment; it looks like a drive-by repair of a flaky/broken base test. If the base test is genuinely broken on v5, it should land as its own fix so the RFC feature PR stays reviewable and bisectable.

Fingerprint: 2cba6990dd7f817ac18880f7885aca8ab42cc51dd52a30f67e2fb5e0fd1d1437

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 31, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 31, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 31, 2026
  4. hivecommons-hive commented on Oct 31, 2026

    @hivecommons-hive
    ContributorAuthor

    Re-targeted: blocker #15973 was superseded by #15999.

  5. hivecommons-hive commented on Oct 31, 2026

    @hivecommons-hive
    ContributorAuthor

    Fixed by #15999 (merged c766074). Closing. Reply /reopen if the problem persists.

  6. removed
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 31, 2026
  7. hivecommons-hive commented on Oct 31, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #15999 is no longer open. This issue is actionable again.

  8. hivecommons-hive commented on Oct 31, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #15999 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions