You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[reviewer] Review backlog (style): Unrelated dashboard test change bundled into RFC card feature PR #15978
Blocked on PR #15973. This finding came from reviewing PR #15973 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.
Filed from an out-of-scope finding in the Hive review of PR #15973.
)
Finding: Unrelated dashboard test change bundled into RFC card feature PR
Commit f3b1eeb changes TestEventTriggersRejectInvalidAndUnpersistedRules (api_event_triggers_test.go:177-178) to point config.RuntimeConfigFile/DashboardOverlayFile at a non-existent directory instead of t.TempDir(). This has no connection to rfcnotify/discord and is not mentioned in the PR body or changelog fragment; it looks like a drive-by repair of a flaky/broken base test. If the base test is genuinely broken on v5, it should land as its own fix so the RFC feature PR stays reviewable and bisectable.
Unblocked: #15999 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
Activity
🐛 test: make dashboard persistence failure fixture deterministic
hivecommons-hive commentedon Oct 31, 2026
Re-targeted: blocker #15973 was superseded by #15999.
🐛 test: make dashboard persistence failure fixture deterministic
test(dashboard): drop unrelated event-trigger fixture change from RFC…
🐛 fix: address review feedback on card labels, wire cleanup, docs and…
✨ feat: render RFC notices as summary-card embeds when rfc_format: ca…
hivecommons-hive commentedon Oct 31, 2026
Fixed by #15999 (merged c766074). Closing. Reply /reopen if the problem persists.
hivecommons-hive commentedon Oct 31, 2026
Unblocked: #15999 is no longer open. This issue is actionable again.
hivecommons-hive commentedon Oct 31, 2026
Unblocked: #15999 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.