Skip to content

[reviewer] Review backlog (security): Private gate relies on nil-safe base.repo.private defaulting to public #15976

Closed

Description

@hivecommons-hive

Filed from an out-of-scope finding in the Hive review of PR #15967.

PR: #15967 (#15967)
Perspective: security
Severity: low (P3)
Evidence: src/pkg/github/sentinel_sweep.go:103 (

Private: pr.GetBase().GetRepo().GetPrivate(),
)
Finding: Private gate relies on nil-safe base.repo.private defaulting to public

Pre-existing from #15933: SentinelPatchObservation.Private is pr.GetBase().GetRepo().GetPrivate(), which reads false (public) when base.repo is absent from the PR payload. The explicit Repos allowlist is the effective guard, so this only matters if an operator allowlists a private repo; consider sourcing privacy from the repo config/API rather than the PR payload.

Fingerprint: 7600fd805678fe58fc17a687bf7de3aa7bf9c04db35f6f50a2ab1822969774ae

filed by Hive review backlog

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 31, 2026
  2. hivecommons-hive commented on Oct 31, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions