Skip to content

[reviewer] Review backlog (correctness): Server.Close does not stop the matrixSource goroutine #15972

Closed

Description

@hivecommons-hive

Filed from an out-of-scope finding in the Hive review of PR #15967.

PR: #15967 (#15967)
Perspective: correctness
Severity: low (P3)
Evidence: src/pkg/dashboard/contribute_ws.go:5072 (

func (s *Server) Close() {
)
Finding: Server.Close does not stop the matrixSource goroutine

pkg/dashboard/contribute_ws.go:5072-5077 Close() only closes the contribute hub; matrixSource.close() (matrix_source.go:134) is never called in production. Harmless for a process-lifetime singleton but leaks the run goroutine in tests/shutdown; wire s.matrix.close() into Server.Close when the endpoint child (#15935) lands.

Fingerprint: e8f47a20e0151d77a909bf1252d8f9a21506de8cbfa2ac6a370c3bb13bd71169

filed by Hive review backlog

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 31, 2026
  2. hivecommons-hive commented on Oct 31, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  3. hivecommons-hive commented on Oct 31, 2026

    @hivecommons-hive
    ContributorAuthor

    Fixed by #15982 (merged 0931a17). Closing. Reply /reopen if the problem persists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions