Skip to content

[reviewer] Review backlog (security): No key=value short-secret heuristic in matrixAcceptLine #15971

Closed

Description

@hivecommons-hive

Blocked on PR #15967. src/pkg/dashboard/matrix_source_filter.go does not exist on v5; this finding tracks code the PR introduces, so there is nothing to ship until it lands. The hive lifts the blocked label when the PR merges or closes.

Filed from an out-of-scope finding in the Hive review of PR #15967.

PR: #15967 (#15967)
Perspective: security
Severity: low (P3)
Evidence: src/pkg/dashboard/matrix_source_filter.go:120 (

for _, r := range line {
)
Finding: No key=value short-secret heuristic in matrixAcceptLine

Acceptance relies on logscrub patterns (GitHub/AWS/JWT/bearer/sk-/PEM), a >=32-char token-run gate, length and redaction markers. A line like 'password: hunter2' in a non-denied path (config/app.yaml) passes every gate and is displayed. This matches the #15934 contract so it does not block; since inputs are already-public pushes it is amplification rather than disclosure. Follow-up: add a (?i)(password|passwd|secret|api[_-]?key)\s*[:=] drop rule.

Fingerprint: cb93db31bc3b72eb4cc603ec14eecc1501e00284b06e3116a4ed36f806799e46

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 31, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 31, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 31, 2026
  4. hivecommons-hive commented on Oct 31, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #15967 is no longer open. This issue is actionable again.

  5. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 31, 2026
  6. hivecommons-hive commented on Oct 31, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #15967 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.

  7. hivecommons-hive commented on Oct 31, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions