Repository navigation
Closed
Labels
agent/scannerCreated or modified by the scanner agentCreated or modified by the scanner agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.hive/likely-doneHive verified that a merged PR references or claims this issue; pending confirmationHive verified that a merged PR references or claims this issue; pending confirmationkind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.
Description
Part of #15869
Goal
In rich mode, announce the lifecycle changes that matter: decisions changed, target or status changed, and needs-decision. Edit the card when an RFC is retitled. Suppress same-author duplicate RFCs. All of this goes into the RFC's thread. None of it happens in line mode.
Applicable decision constraints
- Opt-in only: no new events unless cards or threads are enabled on the designated announcer.
- No duplicate announcements. Bound retries, respect rate limits, surface failures.
- Deferred by the decision, not in this child: the daily comment digest and two-way sync.
Current code (v5)
src/pkg/rfcnotify/rfcnotify.go:Kindisopened/closed/ready.src/pkg/rfcnotify/detector.go:Detector.ObservediffsissueRecordsnapshots. Labels arrive viaIssue.Labels, andstagelabelsis already imported.- The thread mapping comes from the thread-store child and
ParseRFCfrom [scanner] Render RFC notices as summary-card embeds when rfc_format: card #15927.
Changes
- Store in
issueRecord:Title,Target,Status,OpenDecisions,NeedsDecision,DecisionsChangedAt. - New kinds:
KindDecisions: the open-decision count changed, or a decision was struck through or checked. Debounced to at most one notice per RFC per 30 min, using the latest count.KindTargetChanged/KindStatusChanged, detected viaParseRFC.KindNeedsDecision:stage/045-needs-decision(viastagelabels) orneeds-humanwas added.KindRetitled: edit the original card (PATCH /channels/{c}/messages/{m}) and rename the thread (PATCH /channels/{thread}name), without posting a message. AddEditMessageandRenameChannelhelpers tobot.go, with bounded 429 handling.
- Produce these kinds only when
Options.Format == "card"orOptions.Threadsis set. In line mode,Observereturns exactly the events it returns today. - Duplicates. If an RFC is opened with the same normalised title (lowercased, whitespace collapsed, emoji and prefix stripped) and the same author as a record opened within the last hour, post no card. Post
duplicate filed as #Monce into the first RFC's thread and mark the recordDuplicateOf. Closing aDuplicateOfRFC posts nothing.
Decision taken by hive: the 30-minute decisions debounce and the 1-hour duplicate window are fixed constants, as in the RFC, and are not configurable. A retitle edits the card in place rather than posting.
Files
src/pkg/rfcnotify/rfcnotify.go,src/pkg/rfcnotify/detector.go,src/pkg/rfcnotify/sweeper.gosrc/pkg/discord/bot.go(edit/rename helpers + tests)src/pkg/rfcnotify/lifecycle_test.go(new)
Acceptance
- Checking one decision posts one "decisions: 2 → 1 open" line into the thread. A second change within 30 min collapses into the next notice.
- A target change from v5 to v6 posts once. Adding
stage/045-needs-decisionposts once. - A retitle edits the card, renames the thread and posts no new message.
- Two identical RFCs from the same author within an hour produce one card and one thread note. Closing the duplicate posts nothing.
- In line mode, the events in the existing tests stay identical.
- Add
changelog.d/added-rfc-notify-lifecycle.mdand update the docs insrc/docs/notifications.md.
— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88
Metadata
Metadata
Assignees
Labels
agent/scannerCreated or modified by the scanner agentCreated or modified by the scanner agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.hive/likely-doneHive verified that a merged PR references or claims this issue; pending confirmationHive verified that a merged PR references or claims this issue; pending confirmationkind/featureCategorizes issue or PR as related to a new feature.Categorizes issue or PR as related to a new feature.
Activity
hivecommons-hive commentedon Oct 31, 2026
🔒 Claimed by @Karibhou (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply
/unclaimto release, or/claimto take it over if you outrank the holder.hivecommons-hive commentedon Oct 31, 2026
🔓 Claim by @Karibhou released (released on disconnect).
hivecommons-hive commentedon Oct 31, 2026
🔒 Claimed by @Karibhou (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply
/unclaimto release, or/claimto take it over if you outrank the holder.9 remaining items
hivecommons-hive commentedon Oct 31, 2026
Unblocked: the
blockedlabel was applied by the hive without a blocked-on marker, so nothing could lift it. This issue is actionable again.hivecommons-hive commentedon Oct 31, 2026
🔓 Claim by agent
scannerreleased (holding agent relaunched).hivecommons-hive commentedon Oct 31, 2026
Fixed by #16018 (#16018, merged). Closing because Hive's PR claim metadata says this PR was the full fix.