Skip to content

[scanner] Add explicit Exit, Copy link, Full screen and Keep awake controls to Activity Monitor display mode #15929

Closed

Description

@hivecommons-hive

Part of #15860

Give display mode a small pointer-revealed overlay with separate, explicit controls: Exit display, Copy display link, Full screen and Keep screen awake. Each control handles unsupported and denied states gracefully.

Depends on #15925 (the ?display=1 shell) and #15924 (the am.* URL helpers that Copy display link serialises).

Decision constraints that apply (from the maintainer's /hive decision on #15860)

  • Full screen and wake lock must be separate explicit user controls with graceful unsupported/denied states, not automatic requests. Only a click on the matching control may call requestFullscreen() or navigator.wakeLock.request('screen'). Never call them on entering display mode or on load.
  • Reuse the existing pop-out/full-screen shell. The Full screen control calls the existing toggleStageTrackerFullscreen() and does not reimplement it.
  • No display credential, pairing or token in the URL. The copied link contains only view parameters (display=1, am.*, theme) and never a bearer or cookie value.
  • Make no change when display mode is off. Headless ?kiosk=1 never shows the overlay, because it has no pointer and its CSS hides header tools.

Where

What

  • The overlay appears on mousemove / pointerdown / keyboard focus in display mode and hides after 3 s idle. It uses a pure stageTrackerDisplayOverlayVisible(lastPointerMs, nowMs, idleMs).
  • The controls are buttons with aria-labels:
    • Exit display: removes display=1, the same path as Esc in [scanner] Add attended ?display=1 mode with a 📺 header button to the Activity Monitor #15925.
    • Copy display link: navigator.clipboard.writeText(stageTrackerViewUrl(...)) with display=1. If the clipboard is unavailable or refused, show the URL in a selectable field with a toast.
    • Full screen: delegates to toggleStageTrackerFullscreen(). When the Fullscreen API is missing, show it disabled with a "not supported" title.
    • Keep screen awake: toggles a WakeLockSentinel held in memory only. It reports one of four states: unsupported (no navigator.wakeLock, rendered disabled), denied (the request rejected; show the reason, no retry loop), on or off. It re-acquires on visibilitychange only if the user had turned it on, and releases on exit.
  • Use a pure stageTrackerWakeLockState(supported, sentinel, lastError) that returns the label and state for testing.
  • Persist nothing: no localStorage writes for any of these.
  • Document the controls in the display-mode section of src/docs/streaming-the-activity-monitor.md.

Decision taken by hive: the wake-lock on/off state is kept in memory only and is not reapplied after a reload. A reload counts as a new explicit-consent boundary, which matches "not automatic requests".

Acceptance

  • Entering display mode makes no full-screen or wake-lock request. You can verify this with spies in the node test.
  • Each control works on its own. Unsupported and denied states render disabled or with an explanation, never throw, and never retry automatically.
  • In a fresh profile the copied link reproduces the exact filter set and contains no credential.
  • changelog.d/added-activity-monitor-display-controls.md fragment.

Tests

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Activity

  1. added
    kind/featureCategorizes issue or PR as related to a new feature.
    agent/scannerCreated or modified by the scanner agent
    on Oct 31, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 31, 2026
  3. hivecommons-hive commented on Oct 31, 2026

    @hivecommons-hive
    ContributorAuthor

    Consolidated finding. This was filed as a separate issue; it references exactly the same files as this one (AGENTS.md, changelog.d/added-activity-monitor-display-controls.md, src/docs/streaming-the-activity-monitor.md, src/pkg/dashboard/stage_tracker_display.test.js, src/pkg/dashboard/static-src/css/popout.css, src/pkg/dashboard/static-src/js/sections.js, src/pkg/dashboard/static-src/js/tracker-popout.js, src/pkg/dashboard/static/index.html, stage_tracker_popout.test.js, static-src/html/tracker.html), so it was folded in here instead. Address it in the same PR as this issue — two PRs editing the same files would conflict.

    [scanner] Post one Discord thread per RFC with durable idempotent mapping, reconciliation and opt-in backlink

    Part of #15860

    Give display mode a small pointer-revealed overlay with separate, explicit controls: Exit display, Copy display link, Full screen and Keep screen awake. Each control handles unsupported and denied states gracefully.

    Depends on #15925 (the ?display=1 shell) and #15924 (the am.* URL helpers that Copy display link serialises).

    Decision constraints that apply (from the maintainer's /hive decision on #15860)

    • Full screen and wake lock must be separate explicit user controls with graceful unsupported/denied states, not automatic requests. Only a click on the matching control may call requestFullscreen() or navigator.wakeLock.request('screen'). Never call them on entering display mode or on load.
    • Reuse the existing pop-out/full-screen shell. The Full screen control calls the existing toggleStageTrackerFullscreen() and does not reimplement it.
    • No display credential, pairing or token in the URL. The copied link contains only view parameters (display=1, am.*, theme) and never a bearer or cookie value.
    • Make no change when display mode is off. Headless ?kiosk=1 never shows the overlay, because it has no pointer and its CSS hides header tools.

    Where

    What

    • The overlay appears on mousemove / pointerdown / keyboard focus in display mode and hides after 3 s idle. It uses a pure stageTrackerDisplayOverlayVisible(lastPointerMs, nowMs, idleMs).
    • The controls are buttons with aria-labels:
      • Exit display: removes display=1, the same path as Esc in [scanner] Add attended ?display=1 mode with a 📺 header button to the Activity Monitor #15925.
      • Copy display link: navigator.clipboard.writeText(stageTrackerViewUrl(...)) with display=1. If the clipboard is unavailable or refused, show the URL in a selectable field with a toast.
      • Full screen: delegates to toggleStageTrackerFullscreen(). When the Fullscreen API is missing, show it disabled with a "not supported" title.
      • Keep screen awake: toggles a WakeLockSentinel held in memory only. It reports one of four states: unsupported (no navigator.wakeLock, rendered disabled), denied (the request rejected; show the reason, no retry loop), on or off. It re-acquires on visibilitychange only if the user had turned it on, and releases on exit.
    • Use a pure stageTrackerWakeLockState(supported, sentinel, lastError) that returns the label and state for testing.
    • Persist nothing: no localStorage writes for any of these.
    • Document the controls in the display-mode section of src/docs/streaming-the-activity-monitor.md.

    Decision taken by hive: the wake-lock on/off state is kept in memory only and is not reapplied after a reload. A reload counts as a new explicit-consent boundary, which matches "not automatic requests".

    Acceptance

    • Entering display mode makes no full-screen or wake-lock request. You can verify this with spies in the node test.
    • Each control works on its own. Unsupported and denied states render disabled or with an explanation, never throw, and never retry automatically.
    • In a fresh profile the copied link reproduces the exact filter set and contains no credential.
    • changelog.d/added-activity-monitor-display-controls.md fragment.

    Tests

    — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88


    Folded finding. This was filed as a separate issue, but 5 open agent-filed issues already cite src/docs/streaming-the-activity-monitor.md, so it was folded into the oldest of them instead of opening another. Treat this issue as the tracker for that component: prefer one structural fix that covers every folded variant over a PR per variant.

    [scanner] Prepare a disabled-by-default independent hivecommonsfleet broadcast of a public-safe hub activity view

    Part of #15861 (RFC proposed by @hanthor). Fifth implementation child; follows #15965 (Fleet activity page). Nothing here activates a broadcast.

    What

    Prepare an independent, disabled-by-default streamer configuration for the hub-wide monitor, destined for the owner-confirmed channel hivecommonsfleet (https://twitch.tv/hivecommonsfleet):

    • Reuse the existing streamer infrastructure (src/deploy/stream/, src/docs/streaming-the-activity-monitor.md) as a second, separately named deployment: its own source URL, its own credentials reference (a secret name only — never a value), its own process/deployment identity and failure isolation. The existing twitch.tv/hivecommons full-screen Activity Monitor stream is not repurposed, interrupted or changed in any way.
    • The source is a separately authorized public-safe hub view: a dedicated route/flag that renders only content explicitly marked public-safe (public-repo rows, no per-user fleet visibility, no identities beyond what GitHub already shows publicly, no private repository data). Private per-user fleet visibility never authorizes public broadcast.
    • enabled: false is the default and is enforced: with no owner-installed credential and no public-safe policy acknowledgement the deployment refuses to start the encoder.
    • Docs: how an owner enables it, the public-safe content policy, and the explicit statement that dashboard authentication does not protect Twitch output.

    Why

    Owner decisions on #15861 (2026-10-31): dedicated channel and independently configured broadcast; "Twitch output is public regardless of dashboard authentication"; "Keep live broadcast disabled until the owner provisions/authorizes the channel and public-safe content policy. No credentials in issue comments or source." The channel is provisioned; credential installation and public-safe source readiness remain owner actions.

    Acceptance

    • A test/config check proves the hivecommons streamer config is byte-for-byte unchanged by this PR.
    • The new deployment fails closed without credential + explicit enable; the public-safe view omits private rows by construction (test).
    • No credentials in source, config, docs or issue comments.
    • changelog.d/added-*.md fragment.

    Attribution requirement (inherited from #15861)

    Mention @hanthor in the PR description, link #15861 and this child, and mention @hanthor in a completion comment only when the PR actually merges. State what shipped separately from deployment/activation status; never call an open PR, green CI alone or a closed planning ticket completed implementation. Carry this requirement into any further children.

    — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

  4. clubanderson commented on Oct 31, 2026

    @clubanderson
    Member

    @hanthor Tracking implementation of your RFC #15860 here. Implementer requirement: mention @hanthor in the associated PR description, link this issue and RFC #15860, and post a completion comment mentioning @hanthor after the PR actually merges, with the merge link and a clear distinction between source shipped and deployment/activation. This issue is still open; this comment is attribution/notification, not a completion claim.

  5. hivecommons-hive commented on Oct 31, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/scannerCreated or modified by the scanner agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/featureCategorizes issue or PR as related to a new feature.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions