Skip to content

Hive still posts ~65 new comments per 80 min in quiet mode: evidence, unblocked duplicates, awaiting-ci, claim, parking, backlog summary, double closing comments #15918

Closed

Description

@clubanderson

Follow-up to #15875 / #15876. With github.notifications.mode: quiet live on the spoke (d9e14fd) the <!-- hive:status --> edit-in-place path works (10 status comments in 80 min, all edited, none appended) — but in the same 80 minutes the hive still created ~65 new comments on hivecommons/hive, each an email to the author and every watcher.

Tally by marker / first line:

kind count note
<!-- hive-review-evidence --> 13 one evidence-bundle pointer comment per merged PR; the bundle is already stored server-side and linked from the Activity Monitor
<!-- hive:unblocked --> 9 duplicates: #15536 ×2 within a minute, #15740 ×2 — the sweep sees the issue again before the label removal is visible / a second sweep path lifts the same block and re-posts
hive/awaiting-ci: CI pending — sweep will merge… 2 agent status note relayed as a comment
<!-- hive:claim … --> 2 contribute-hub claim marker comment
hive-close-on-merge "Fixed by #N" + hive:closed-by-merged-pr "Fixed by #N" 2+ both closing comments on the same issue (#15727 vs #15843 pattern)
Already fixed … 2 agent note before a close
Parking on stage/045-needs-decision … 2 agent parking note
<!-- hive:review-backlog-summary v1 --> 2 backlog summary per PR
<!-- hive:status --> 10 the good ones (edited in place)

Required in quiet mode (default):

  1. hive-review-evidence → an Evidence: section of the hive:status comment, not its own comment.
  2. hive:unblocked → idempotent per (issue, settled PR) in either mode — never post the same note twice; in quiet mode fold into the status comment on the issue; skip entirely when the same merge is closing the issue.
  3. hive/awaiting-ci, hive:claim, Parking on stage/045…, Already fixed, review-backlog-summary → status comment sections, not new comments.
  4. Closing an issue leaves ONE closing comment: never both the close-on-merge "Fixed by #N" and the issue-stage lane "Fixed by #N (merged). Closing because Hive PR claim metadata…".
  5. A cheap counter: one INFO line per hour github notifications created=N edited=M suppressed=K so the effect can be measured from logs.
  6. Tests for idempotent unblocked, evidence folding, single closing comment, the hourly counter.

normal mode keeps the current behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions