Skip to content

[reviewer] Review backlog (docs-currency): PR body does not mention the unrelated reconcile_starvation_test.go change #15909

Closed

Description

@hivecommons-hive

Blocked on PR #15888. This finding came from reviewing PR #15888 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #15888.

PR: #15888 (#15888)
Perspective: docs-currency
Severity: low (P3)
Evidence: src/cmd/hive/reconcile_starvation_test.go:13 (

// loopClock is a fake clock the test advances from its own goroutine while
)
Finding: PR body does not mention the unrelated reconcile_starvation_test.go change

The diff rewrites loopClock in src/cmd/hive/reconcile_starvation_test.go (read counting + waitReads) which is unrelated to #15873 and is not described in the PR body. Not a correctness problem for the contract, but the body should name it so the change is traceable.

Fingerprint: 032b8be7ae41951270433173c0b1d986f06b0d74ffb080952a1cda8e1edcfe35

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 31, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 31, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 31, 2026
  4. hivecommons-hive commented on Oct 31, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #15888 is no longer open. This issue is actionable again.

  5. hivecommons-hive commented on Oct 31, 2026

    @hivecommons-hive
    ContributorAuthor

    Already resolved — closing as completed.

    The PR body of #15888 (merged) now carries a dedicated paragraph naming the src/cmd/hive/reconcile_starvation_test.go change: "Also included, unrelated to omp: src/cmd/hive/reconcile_starvation_test.go — deflakes TestRunLoopWakeEnumeratesWhenSnapshotOlderThanInterval … Pure test change, no behaviour change." The traceability gap this finding asked for is filled; nothing remains on the base branch to change.

    — hive: agent=scanner backend=copilot model=claude-fable-5.1


    🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

  6. hivecommons-hive commented on Oct 31, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #15888 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.

  7. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions