Repository navigation
Description
Verified runtime/source defect
Focused follow-up to #15886/#15883 and the serial preparation lifecycle in #15836; not a new reviewer engine or UI scope.
The rolled Hive binary d9e14fdbaed95423ad8e41946fdda94c07ac89b6 includes #15886/#15887. Durable preparation owner #15893 was selected at 2026-10-30T23:48:09Z with admitted head 37e0c945b92371a0a0df93bb65b757a6d80a21a6; its persisted attempt records that head and base cccbf34a4e86e7f7cde03be0d610a84ac0201aae.
Git-authoritative commit f33135aced8c44c83bd1116d2c4034979bb305f6 is Hive's own refresh: first parent 37e0c945b92371a0a0df93bb65b757a6d80a21a6, second parent 3c7d442d4ee47de19ca19f6356a8648055c77d4b, which descends from the recorded base. GitHub GraphQL attributes its author to hivecommons-hive[bot]. Against the recorded stale base, before/after three-dot diffs have 3 versus 115 changed files. Against the actual merged destination base, both have the same 3-file normalized patch and identical resulting blobs for all three files.
Engine.ActiveBasePreparation currently rejects a refreshed head unless its second parent exactly equals persisted Attempt.Base, then compares patches against that recorded base. Thus this legitimate own refresh is excluded before priority despite durable ownership surviving the cold restart. Merely relaxing parent equality while keeping the stale-base patch comparison would also fail.
Important distinction
At 2026-10-31T00:03:39.696Z the new pod reported #15893 no-free-reviewer while four merge-ready reviews went to hotshot#330. All required checks were green, but the main ARM64 image check was still IN_PROGRESS (run41146614549/job124373160469); the planner deliberately requires settled CI for owner promotion. That pass alone therefore does not prove a scheduling-policy violation, and pending CI must remain ineligible. awaiting-review-approval is an internal artifact outcome, not proof that all CI is settled or that GitHub review responses are absent.
Bounded fix
Reuse the existing App-authored base-refresh ancestry/content checker already available on the automerge engine. Validate the recorded attempted head through the actual destination branch and unchanged content rather than treating a mutable/stale base SHA as the required second parent. Support existing persisted owners after restart without mutating or rewriting ownership/attempt records. Keep exact live-head binding, terminal/hold/expiry/release checks, current-base/CI/review gates, reviewer capacity and confirmed-service fairness unchanged; no UI DTO, publisher, integration-layer, pool/configuration or deployment changes.
Regression coverage: own refresh with advanced base after durable reload; wrong branch/non-App/content-changing heads rejected; pending CI still not promoted; existing lifecycle/fairness/no-owner behavior retained. CI only per AGENTS. Owner authorizes guarded administrative source merge only after terminal exact-head CI/build/lint green; no rollout.
Activity