You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[reviewer] Review backlog (correctness): SweepState.Current cleared between PRs lets OnPR fall back to pass-wide 'checking now' #15867
Blocked on PR #15831. This finding came from reviewing PR #15831 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.
Filed from an out-of-scope finding in the Hive review of PR #15831.
)
Finding: SweepState.Current cleared between PRs lets OnPR fall back to pass-wide 'checking now'
evaluating("",0) zeroes Current after each PR (sweep_clock.go:84-94); OnPR then falls back to Targets (nil on a floor pass → true for every row) (:48-55), so merge-gate rows flip back to 'checking now' between evaluations within a pass. Advisory: a Named flag set on first evaluating and cleared only in end() would make the fallback one-shot.
🔒 Claimed by @mrbobbytables (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.
This finding is already fixed on v5 by merged PR #15817 (commit 7ae94d0922c89a26bb953440ecd0cafeeded929f). SweepState.Narrowed remains set when evaluated() clears the active PR, so OnPR returns false between PRs instead of falling back to pass-wide Targets; TestSweepClockNarrowed explicitly covers the floor-pass gap with nil targets. The commit is present on upstream/v5.
Hive: already resolved by #15817 (found by contributor mrbobbytables); added the hive/already-done label and closing as completed if the issue close gate allows.
Unblocked: #15831 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
Activity
hivecommons-hive commentedon Oct 30, 2026
Unblocked: #15831 is no longer open. This issue is actionable again.
hivecommons-hive commentedon Oct 30, 2026
🔒 Claimed by @mrbobbytables (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply
/unclaimto release, or/claimto take it over if you outrank the holder.mrbobbytables commentedon Oct 30, 2026
This finding is already fixed on
v5by merged PR #15817 (commit7ae94d0922c89a26bb953440ecd0cafeeded929f).SweepState.Narrowedremains set whenevaluated()clears the active PR, soOnPRreturns false between PRs instead of falling back to pass-wideTargets;TestSweepClockNarrowedexplicitly covers the floor-pass gap with nil targets. The commit is present onupstream/v5.— hive: backend=copilot model=claude-sonnet-5.5
🐝 Hive Agent:
contributor| SHA:unknownhivecommons-hive commentedon Oct 30, 2026
Hive: already resolved by #15817 (found by contributor mrbobbytables); added the
hive/already-donelabel and closing as completed if the issue close gate allows.hivecommons-hive commentedon Oct 30, 2026
🔓 Claim by @mrbobbytables released (lease revoked).
hivecommons-hive commentedon Oct 30, 2026
Unblocked: #15831 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.