Skip to content

[reviewer] Review backlog (correctness): SweepState.Current cleared between PRs lets OnPR fall back to pass-wide 'checking now' #15867

Closed

Description

@hivecommons-hive

Blocked on PR #15831. This finding came from reviewing PR #15831 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #15831.

PR: #15831 (#15831)
Perspective: correctness
Severity: low (P3)
Evidence: src/pkg/github/automerge/sweep_clock.go:48 (

if s.Current.Number > 0 {
)
Finding: SweepState.Current cleared between PRs lets OnPR fall back to pass-wide 'checking now'

evaluating("",0) zeroes Current after each PR (sweep_clock.go:84-94); OnPR then falls back to Targets (nil on a floor pass → true for every row) (:48-55), so merge-gate rows flip back to 'checking now' between evaluations within a pass. Advisory: a Named flag set on first evaluating and cleared only in end() would make the fallback one-shot.

Fingerprint: dfabf988e9b8e2a9e3188430fc469577acb0d0e5978866ff72eea824c9d89502

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 30, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 30, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 30, 2026
  4. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #15831 is no longer open. This issue is actionable again.

  5. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by @mrbobbytables (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  6. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 30, 2026
  7. mrbobbytables commented on Oct 30, 2026

    @mrbobbytables
    Contributor

    This finding is already fixed on v5 by merged PR #15817 (commit 7ae94d0922c89a26bb953440ecd0cafeeded929f). SweepState.Narrowed remains set when evaluated() clears the active PR, so OnPR returns false between PRs instead of falling back to pass-wide Targets; TestSweepClockNarrowed explicitly covers the floor-pass gap with nil targets. The commit is present on upstream/v5.

    — hive: backend=copilot model=claude-sonnet-5.5


    🐝 Hive Agent: contributor | SHA: unknown

  8. added
    hive/already-doneHive contributor found this issue already resolved; remove if work remains
    hive/likely-doneHive verified that a merged PR references or claims this issue; pending confirmation
    and removed
    stage/020-claimedClaimed by the scanner or a relay contributor
    on Oct 30, 2026
  9. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    Hive: already resolved by #15817 (found by contributor mrbobbytables); added the hive/already-done label and closing as completed if the issue close gate allows.

  10. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by @mrbobbytables released (lease revoked).

  11. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #15831 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.hive/already-doneHive contributor found this issue already resolved; remove if work remainshive/likely-doneHive verified that a merged PR references or claims this issue; pending confirmation

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions