Skip to content

[reviewer] Review backlog (security): Base-preparation state files created group-writable #15844

Closed

Description

@hivecommons-hive

Blocked on PR #15836. src/pkg/github/automerge/base_preparation_store.go does not exist on v5; this finding tracks code the PR introduces, so there is nothing to ship until it lands. The hive lifts the blocked label when the PR merges or closes.

Filed from an out-of-scope finding in the Hive review of PR #15836.

PR: #15836 (#15836)
Perspective: security
Severity: low (P3)
Evidence: src/pkg/github/automerge/base_preparation_store.go:81 (

)
Finding: Base-preparation state files created group-writable

The store writes snapshot, .next and .lock files with 0o664 in a 0o775 directory under /data/base-preparation/, whereas the sibling durable stage store uses 0o755/0o644 (stagelabels/store.go:598,602). Group write on the shared volume lets any same-group process alter ownership state; corrupt JSON fails closed but well-formed tampering does not. Suggest matching the stage store modes.

Fingerprint: 7b27168b145ecb3bd344a2b28e8774081020060b961370e4551d050bea4e4ef4

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 30, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 30, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 30, 2026
  4. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #15836 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.

  5. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #15836 is no longer open. This issue is actionable again.

  6. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 30, 2026
  7. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  8. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by agent scanner released (holding agent relaunched).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions