You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
π Reviewer slots wasted: verdicts discarded after head moves, no merge-readiness ordering, canary-only audit previewsΒ #15823
Observed on hive's own spoke (v5 db43b1a, 2026-10-30 ~11:00β12:10 ET): reviewer capacity is the merge bottleneck (autoscale at max, backlog 8, oldest wait 19m, train PRs logging `review dispatch waiting: perspectives still owed, no reviewer this cycle` reason=no-parallel-slot). Three wastes:
A) Verdicts discarded across a head move. 16 verdicts in 3h logged by `pkg/github/review_verdict_relay.go` "review-request watcher: verdict matched no dispatch row for its agent, falling back to advisory". Example: reviewed=#15783 agent=ci-maintainer perspective=correctness reported_head=e04062a5β¦ while every candidate dispatch row has head=3fde88faβ¦ (previous head). The PR got a push (rebase / merge-from-base) between dispatch and verdict; the verdict for the live head is demoted to advisory, the perspective stays owed and is re-dispatched β one slot burned, zero progress. The row lookup also requires `agent == dispatched agent`, so a verdict from another reviewer-role agent for the same (pr, perspective) is rejected too.
Fix: accept a verdict whose head differs from the dispatch row when (i) the reviewer's reported head is the PR's current head, or (ii) the two heads carry the same patch relative to base (compare shows no tree difference). Record under the current head, mark the perspective satisfied, rewrite the in-flight row's head, log INFO `verdict accepted across head move pr=N h1=β¦βh2=β¦ why=reported-current-head|same-patch`. Relax the agent match to any reviewer-role agent.
B No readiness-based review ordering. Review dispatch planning spends slots in queue order plus a starvation promotion, but a PR whose verdict is the ONLY thing blocking merge (CI green, mergeable) should go before PRs still pending/red in CI or conflicting. Add ordering: merge-blocked-only-by-verdict β starved β age; expose the reason in the dispatch log (priority=merge-ready); defer pending-CI heads unless slots would otherwise go unused.
C) Security-canary kicks. 9 of 30 agent kicks in 3h showed only SECURITY CANARY: HIVE-CANARY-β¦ in the audit: agent kicked preview. The preamble is ~200 bytes, exactly the preview cap, so operators cannot see the real work message. Make the preview/snippet start after the preamble (kick content unchanged, canary coverage unchanged), and keep the no-work β no-kick guarantee.
EOF
)
π Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.
Activity
hivecommons-hive commentedon Oct 30, 2026
π Claimed by agent
scanner(agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply/unclaimto release, or/claimto take it over if you outrank the holder.π Accept review verdicts across head moves and order reviewer slots bβ¦