Skip to content

Review backlog (correctness): Watcher hot-reload degrades launch_cmd without raising the dashboard alert #15770

Closed

Description

@hivecommons-hive

Blocked on PR #15750. This finding came from reviewing PR #15750 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #15750.

PR: #15750 (#15750)
Perspective: correctness
Severity: low (P3)
Evidence: src/pkg/dashboard/api.go:31 (

s.surfaceLaunchCmdDegradations()
)
Finding: Watcher hot-reload degrades launch_cmd without raising the dashboard alert

surfaceLaunchCmdDegradations is called only from RegisterAPI (api.go:31). The config watcher's reload (pkg/config/watcher.go:137, LoadWithDashboardOverlay) also runs DegradeContradictingLaunchCmds, so a hive.yaml hand-edited into contradiction after boot is silently degraded with an ERROR log but no launch-cmd-degraded- banner. The onChange consumer should re-run surfaceLaunchCmdDegradations (or RegisterAPI's equivalent) after swapping s.deps.Config.

Fingerprint: 00f64a1f65a8e49c6a1fb0a43a9ba0a9cf48ac7ff5e8deed3c96998cd2e37a1c

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 30, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 30, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 30, 2026
  4. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #15750 is no longer open. This issue is actionable again.

  5. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 30, 2026
  6. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    Closed as completed: #15750 merged and launch_cmd is no longer in src/pkg/dashboard/api.go on v5, so this finding no longer applies. Reopen if it does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions