You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Review backlog (correctness): Watcher hot-reload degrades launch_cmd without raising the dashboard alert #15770
Blocked on PR #15750. This finding came from reviewing PR #15750 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.
Filed from an out-of-scope finding in the Hive review of PR #15750.
)
Finding: Watcher hot-reload degrades launch_cmd without raising the dashboard alert
surfaceLaunchCmdDegradations is called only from RegisterAPI (api.go:31). The config watcher's reload (pkg/config/watcher.go:137, LoadWithDashboardOverlay) also runs DegradeContradictingLaunchCmds, so a hive.yaml hand-edited into contradiction after boot is silently degraded with an ERROR log but no launch-cmd-degraded- banner. The onChange consumer should re-run surfaceLaunchCmdDegradations (or RegisterAPI's equivalent) after swapping s.deps.Config.
Closed as completed: #15750 merged and launch_cmd is no longer in src/pkg/dashboard/api.go on v5, so this finding no longer applies. Reopen if it does.
Activity
hivecommons-hive commentedon Oct 30, 2026
Unblocked: #15750 is no longer open. This issue is actionable again.
hivecommons-hive commentedon Oct 30, 2026
Closed as completed: #15750 merged and
launch_cmdis no longer insrc/pkg/dashboard/api.goon v5, so this finding no longer applies. Reopen if it does.