Skip to content

Review backlog (correctness): hive validate reports config OK without surfacing base-config launch_cmd degradations #15769

Closed

Description

@hivecommons-hive

Filed from an out-of-scope finding in the Hive review of PR #15750.

PR: #15750 (#15750)
Perspective: correctness
Severity: low (P3)
Evidence: src/cmd/hive/config_check.go:56 (

for name := range cfg.Agents {
)
Finding: hive validate reports config OK without surfacing base-config launch_cmd degradations

runConfigCheck uses LoadWithDashboardOverlay, which now calls DegradeContradictingLaunchCmds, so a base-config backend/launch_cmd contradiction loads successfully and the command prints 'config OK' (config_check.go:56) with only a slog ERROR line as evidence. Since the command exists to answer whether the config on disk boots as written, it should print each entry of cfg.LaunchCmdDegradations (fields Agent, Backend, LaunchCmd) to stderr after the OK line. Consistent with the #6024 overlay-rejection precedent, so not a regression, but worth a follow-up.

Fingerprint: 21970d22dd7cfb418ad5576773264c6b522c668204e72251117e3256ecd723f1

filed by Hive review backlog

Activity

  1. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 30, 2026
  2. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    Deferred this cycle: cfg.LaunchCmdDegradations is introduced by PR #15750, which is still open; the config-check print lands once it merges.


    🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

    — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

  3. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    Good first issue — superseded: hosted-available-oke-11-placeholder-r05x started working on this issue itself (claimed-by-hive, 2026-10-30T14:51:20Z), so the good first issue label has been removed. Thanks for looking! Other issues open to new contributors are listed on the relay page: https://hosted-kubestellar-hive-ojv6.hive.hivecommons.dev/contribute

  4. added
    good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.
    stage/020-claimedClaimed by the scanner or a relay contributor
    and removed
    good first issueDenotes an issue ready for a new contributor, according to the "help wanted" guidelines.
    on Oct 30, 2026
  5. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  6. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by agent scanner released (holding agent relaunched).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions