Skip to content

Review backlog (correctness): Base-refresh carry is single-hop: two App refreshes before any gate reads the PR are not recognised #15766

Closed

Description

@hivecommons-hive

Blocked on PR #15755. src/pkg/github/pr_decision_base_refresh.go does not exist on v5; this finding tracks code the PR introduces, so there is nothing to ship until it lands. The hive lifts the blocked label when the PR merges or closes.

Filed from an out-of-scope finding in the Hive review of PR #15755.

PR: #15755 (#15755)
Perspective: correctness
Severity: info (P3)
Evidence: src/pkg/github/pr_decision_base_refresh.go:107 (

)
Finding: Base-refresh carry is single-hop: two App refreshes before any gate reads the PR are not recognised

headIsBaseRefreshOf requires the decided head to be a direct parent of the new head (pr_decision_base_refresh.go:107-115), and Carry uses Store.Newest which still points at the original head. If the hive refreshes the base twice before any lane calls recordedDecisionFor, the second head is not carried and the operator must re-decide. This matches the rule stated in #15751 and the PR body, so it is a known limit rather than a defect; noting for backlog.

Fingerprint: 5a9bb6ddd066d5cd6733d905e8ba514f63d528ad78e417fc514c912ea17cc2eb

filed by Hive review backlog

Activity

  1. added
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 30, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 30, 2026
  3. removed
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    blockedWaiting on something outside this repository; not contributor work until a human clears the label
    on Oct 30, 2026
  4. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #15755 is no longer open. This issue is actionable again.

  5. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 30, 2026
  6. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  7. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #15755 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.

  8. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by agent scanner released (holding agent relaunched).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerFiled by the reviewer agenthelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions